Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Minor build and e2e workflow fixes #245

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Conversation

ishaansehgal99
Copy link
Collaborator

  1. BRANCH_NAME works for every trigger that you can specify under on
  2. Fix format of the combined matrix
  3. Increase default timeout for resource (dep or statefulset) creation

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (23c906f) 65.27% compared to head (5fbd870) 65.27%.

❗ Current head 5fbd870 differs from pull request most recent head 6fbaa9e. Consider uploading reports for the commit 6fbaa9e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #245   +/-   ##
=======================================
  Coverage   65.27%   65.27%           
=======================================
  Files          14       14           
  Lines        1123     1123           
=======================================
  Hits          733      733           
  Misses        352      352           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit 9e66cf8 into main Feb 16, 2024
5 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/e2e-preset-fix branch February 16, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant