Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ensured nodes being deleted aren't considered Qualified Nodes #259

Closed
wants to merge 1 commit into from

Conversation

ishaansehgal99
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 65.15%. Comparing base (de2b45c) to head (175ebea).

Files Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #259      +/-   ##
==========================================
- Coverage   65.27%   65.15%   -0.12%     
==========================================
  Files          14       14              
  Lines        1123     1125       +2     
==========================================
  Hits          733      733              
- Misses        352      353       +1     
- Partials       38       39       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 changed the title fix: Ensure Qualified Nodes aren't being deleted fix: Ensured nodes being deleted aren't considered Qualified Nodes Feb 28, 2024
@ishaansehgal99
Copy link
Collaborator Author

Included in #256

@ishaansehgal99 ishaansehgal99 deleted the Ishaan/fix-valid-resource branch May 8, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant