Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add model version #297

Closed
wants to merge 23 commits into from
Closed

feat: Add model version #297

wants to merge 23 commits into from

Conversation

etredal
Copy link

@etredal etredal commented Mar 13, 2024

No description provided.

@codecov Codecov
Copy link

codecov bot commented Mar 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.71%. Comparing base (ea83144) to head (f298777).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #297   +/-   ##
=======================================
  Coverage   61.71%   61.71%           
=======================================
  Files          14       14           
  Lines        1191     1191           
=======================================
  Hits          735      735           
  Misses        418      418           
  Partials       38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99
Copy link
Collaborator

There are two things left to do:

  1. CI/CD: Bump up all the model versions by 0.0.1 in supported_models.yaml, this will trigger the build pipeline
  2. Test: Add test for the new endpoint in e2e-preset-test.yaml and text-generation/tests/test_inference_api.py (would also recommend testing the endpoint in own env)

@etredal etredal changed the title Etredal/add model version Feat: Add model version Mar 14, 2024
@etredal etredal changed the title Feat: Add model version feat: Add model version Mar 14, 2024
@ishaansehgal99
Copy link
Collaborator

Included in #341 (To run pipelines)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishaansehgal99 ishaansehgal99 ishaansehgal99 approved these changes

@Fei-Guo Fei-Guo Awaiting requested review from Fei-Guo Fei-Guo is a code owner

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etredal @ishaansehgal99 @codecov-commenter