Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Update release workflow #319

Merged
merged 4 commits into from
Mar 29, 2024
Merged

ci: Update release workflow #319

merged 4 commits into from
Mar 29, 2024

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented Mar 26, 2024

Reason for Change:

  • Automate the release workflow.
  • Use Reusable workflows instead of workflow_dispatch. This will enhance the usability of e2e pipeline.
  • Remove unnecessary jobs.
  • Fix goreleaser to pick the current tag.
  • Add option to update k8s version for upcoming pipelines.

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

@helayoty helayoty added the ok-to-test PR is ready to run tests label Mar 26, 2024
@helayoty helayoty force-pushed the helayoty/update-workflows branch 4 times, most recently from 3bcb209 to e99100e Compare March 26, 2024 20:35
@helayoty helayoty removed the ok-to-test PR is ready to run tests label Mar 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.87%. Comparing base (e1673aa) to head (44994dc).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   61.71%   63.87%   +2.16%     
==========================================
  Files          14       14              
  Lines        1191     1301     +110     
==========================================
+ Hits          735      831      +96     
- Misses        418      432      +14     
  Partials       38       38              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.github/workflows/publish-acr-image.yml Outdated Show resolved Hide resolved
.github/workflows/publish-acr-image.yml Outdated Show resolved Hide resolved
Signed-off-by: Heba Elayoty <[email protected]>
Signed-off-by: Heba Elayoty <[email protected]>
Signed-off-by: Heba Elayoty <[email protected]>
@Fei-Guo Fei-Guo merged commit d079f36 into main Mar 29, 2024
4 of 5 checks passed
@Fei-Guo Fei-Guo deleted the helayoty/update-workflows branch March 29, 2024 00:21
helayoty added a commit that referenced this pull request Mar 29, 2024
**Reason for Change**:
- Automate the release workflow.
- Use [Reusable
workflows](https://docs.github.com/en/actions/using-workflows/reusing-workflows#reusable-workflows-and-starter-workflows)
instead of workflow_dispatch. This will enhance the usability of e2e
pipeline.
- Remove unnecessary jobs.
- Fix goreleaser to pick the current tag.
- Add option to update k8s version for upcoming pipelines.

**Requirements**
- [ ] added unit tests and e2e tests (if applicable).

**Issue Fixed**:
<!-- If this PR fixes GitHub issue 4321, add "Fixes #4321" to the next
line. -->

**Notes for Reviewers**:

---------

Signed-off-by: Heba Elayoty <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants