Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Util funcs, updating func names, logs, configs and ensure service requirement #485

Merged
merged 10 commits into from
Jun 28, 2024
Merged

feat: Add Util funcs, updating func names, logs, configs and ensure service requirement #485

merged 10 commits into from
Jun 28, 2024
+92 −30

Conversation

ishaansehgal99
Copy link
Collaborator

Reason for Change:
Renaming functions, updating configs and services

@ishaansehgal99 ishaansehgal99 changed the title nits: Renaming functions, updating configs and services nits: Adding Util functions, Renaming functions, updating configs and services Jun 27, 2024
@ishaansehgal99 ishaansehgal99 changed the title nits: Adding Util functions, Renaming functions, updating configs and services nits: Adding Util funcs, Renaming funcs, updating logs, configs and ensure service requirement Jun 27, 2024
@ishaansehgal99 ishaansehgal99 changed the title nits: Adding Util funcs, Renaming funcs, updating logs, configs and ensure service requirement nits: Adding Util funcs, updating func names, logs, configs and ensure service requirement Jun 27, 2024
@ishaansehgal99 ishaansehgal99 changed the title nits: Adding Util funcs, updating func names, logs, configs and ensure service requirement nits: Add Util funcs, updating func names, logs, configs and ensure service requirement Jun 27, 2024
@ishaansehgal99 ishaansehgal99 changed the title nits: Add Util funcs, updating func names, logs, configs and ensure service requirement feat: Add Util funcs, updating func names, logs, configs and ensure service requirement Jun 27, 2024
@codecov Codecov
Copy link

codecov bot commented Jun 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 61.02%. Comparing base (45e75aa) to head (40c32d1).
Report is 3 commits behind head on main.

Files Patch % Lines
pkg/controllers/workspace_controller.go 0.00% 6 Missing ⚠️
pkg/inference/preset-inferences.go 0.00% 0 Missing and 1 partial ⚠️
pkg/tuning/preset-tuning.go 80.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #485      +/-   ##
==========================================
+ Coverage   60.92%   61.02%   +0.09%     
==========================================
  Files          29       29              
  Lines        2559     2568       +9     
==========================================
+ Hits         1559     1567       +8     
- Misses        909      910       +1     
  Partials       91       91

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ishaansehgal99 ishaansehgal99 merged commit f534355 into main Jun 28, 2024
7 of 10 checks passed
@ishaansehgal99 ishaansehgal99 deleted the Ishaan/preset-test branch June 28, 2024 17:41
smritidahal653 pushed a commit to smritidahal653/kaito that referenced this pull request Jul 12, 2024
@ishaansehgal99 @smritidahal653
feat: Add Util funcs, updating func names, logs, configs and ensure s…
edb3f68 
…ervice requirement (kaito-project#485)

**Reason for Change**:
Renaming functions, updating configs and services
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fei-Guo Fei-Guo Fei-Guo approved these changes

@helayoty helayoty Awaiting requested review from helayoty helayoty is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ishaansehgal99 @Fei-Guo