Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update nodeClaim manifest and add nodeClass #509

Merged
merged 4 commits into from
Jul 20, 2024

Conversation

helayoty
Copy link
Collaborator

@helayoty helayoty commented Jul 11, 2024

Reason for Change:

  • Update nodeClaim manifest:

    • Use ResourceEphemeralStorage instead of ResourceStorage
    • Add LabelInstanceTypeStable to the Node Selector.
  • Check if NodeClass for either Azure or AWS cases has been created. if not, the controller will create it automatically.

  • Add nodeClaim error handle for plugin error case.

  • Update go toolchain to 1.22.5 to be able to import karpenter/aws
    Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 24.17582% with 69 lines in your changes missing coverage. Please review.

Project coverage is 59.15%. Comparing base (ed546f0) to head (1bb8414).
Report is 12 commits behind head on main.

Files Patch % Lines
pkg/nodeclaim/nodeclaim.go 24.35% 58 Missing and 1 partial ⚠️
pkg/controllers/workspace_controller.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
- Coverage   61.10%   59.15%   -1.96%     
==========================================
  Files          29       30       +1     
  Lines        2602     2693      +91     
==========================================
+ Hits         1590     1593       +3     
- Misses        921     1008      +87     
- Partials       91       92       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you move all aws related code to another PR (more UT tests may be needed to test AWS
enablement) so that this PR will be more focused.

pkg/nodeclaim/nodeclaim.go Outdated Show resolved Hide resolved
pkg/utils/common.go Outdated Show resolved Hide resolved
pkg/nodeclaim/nodeclaim.go Outdated Show resolved Hide resolved
@helayoty helayoty merged commit 531207e into main Jul 20, 2024
6 of 8 checks passed
@helayoty helayoty deleted the helayoty/update-nodeclaim branch July 20, 2024 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants