-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update nodeClaim manifest and add nodeClass #509
Conversation
955a5e4
to
b2c621f
Compare
b32fc6a
to
7e162c8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #509 +/- ##
==========================================
- Coverage 61.10% 59.15% -1.96%
==========================================
Files 29 30 +1
Lines 2602 2693 +91
==========================================
+ Hits 1590 1593 +3
- Misses 921 1008 +87
- Partials 91 92 +1 ☔ View full report in Codecov by Sentry. |
9653399
to
2564a12
Compare
1ec0c11
to
d62edf0
Compare
d62edf0
to
25b573f
Compare
25b573f
to
5e58ee7
Compare
5e58ee7
to
d9437c0
Compare
d9437c0
to
1d6ff29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move all aws related code to another PR (more UT tests may be needed to test AWS
enablement) so that this PR will be more focused.
Signed-off-by: Heba Elayoty <[email protected]>
Signed-off-by: Heba Elayoty <[email protected]>
Signed-off-by: Heba Elayoty <[email protected]>
1d6ff29
to
9b30877
Compare
Signed-off-by: Heba Elayoty <[email protected]>
Reason for Change:
Update nodeClaim manifest:
ResourceEphemeralStorage
instead ofResourceStorage
LabelInstanceTypeStable
to the Node Selector.Check if NodeClass for either Azure or AWS cases has been created. if not, the controller will create it automatically.
Add nodeClaim error handle for plugin error case.
Update go toolchain to 1.22.5 to be able to import karpenter/aws
Requirements
added unit tests and e2e tests (if applicable).
Issue Fixed:
Notes for Reviewers: