New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Deployments for E2E Tests #60

Merged

Fei-Guo merged 8 commits into main from Ishaan/deployment-files

Oct 13, 2023

Collaborator

ishaansehgal99 commented Oct 11, 2023 •

edited

Loading

This PR introduces the deployment files applied by GitHub E2E action for inference testing. This PR also includes the conversion deployment for DADI.


          feat: add deployments

ca59e5a

ishaansehgal99 requested review from Fei-Guo and helayoty as code owners

October 11, 2023 22:13


          fix: remove file included by mistake

252a399

helayoty reviewed

View reviewed changes

pkg/presets/k8s/falcon-7b-instruct/falcon-7b-instruct-service.yaml Outdated Show resolved Hide resolved

helayoty reviewed

View reviewed changes

pkg/presets/k8s/falcon-7b-instruct/falcon-7b-instruct-statefulset.yaml Outdated Show resolved Hide resolved

helayoty reviewed

View reviewed changes

pkg/presets/k8s/falcon-7b/falcon-7b-service.yaml Outdated Show resolved Hide resolved

helayoty reviewed

View reviewed changes

pkg/presets/k8s/falcon-7b/falcon-7b-statefulset.yaml Outdated Show resolved Hide resolved

helayoty reviewed

View reviewed changes

pkg/presets/k8s/llama-2-7b-chat/llama-2-7b-chat-service.yaml Outdated Show resolved Hide resolved

helayoty reviewed

View reviewed changes

pkg/presets/k8s/llama-2-7b/llama-2-7b-service.yaml Outdated Show resolved Hide resolved

helayoty reviewed

View reviewed changes

pkg/presets/k8s/convert_fill.sh Outdated Show resolved Hide resolved

helayoty previously requested changes

View reviewed changes

Collaborator

helayoty left a comment

Why did we add the k8s folder under pkg? If these are the presets, then we need to move them there.

ishaansehgal99 added 6 commits

October 12, 2023 23:19


          fix: clean deployment add repo placeholder

779d17b


          fix: moved deployments to right folder

5c3ffe6


          fix: move into correct folder

42ea5f0


          fix: moved convert to hack


          fix: updated dockerfiles to point to new presets dir

d754465


          Merge branch 'main' into Ishaan/deployment-files

4dc559f

helayoty reviewed

View reviewed changes

Collaborator

helayoty left a comment

lgtm , deferring approval for @Fei-Guo

Fei-Guo approved these changes

View reviewed changes

Fei-Guo dismissed helayoty’s stale review

October 13, 2023 18:22

done

Fei-Guo merged commit 4801723 into main

5 checks passed

Fei-Guo deleted the Ishaan/deployment-files branch

October 13, 2023 18:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet