-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Nodeclaim & Machine provision to RAG Engine controller #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bangqipropel
requested review from
Fei-Guo,
helayoty and
ishaansehgal99
as code owners
October 9, 2024 08:47
bangqipropel
had a problem deploying
to
unit-tests
October 9, 2024 08:47
— with
GitHub Actions
Error
bangqipropel
force-pushed
the
bangqipropel/RAG_controller
branch
from
October 9, 2024 08:50
442d8ff
to
d6d7a18
Compare
bangqipropel
temporarily deployed
to
unit-tests
October 9, 2024 08:50
— with
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #622 +/- ##
==========================================
- Coverage 58.18% 52.85% -5.34%
==========================================
Files 30 34 +4
Lines 2987 4221 +1234
==========================================
+ Hits 1738 2231 +493
- Misses 1149 1870 +721
- Partials 100 120 +20 ☔ View full report in Codecov by Sentry. |
bangqipropel
force-pushed
the
bangqipropel/RAG_controller
branch
from
October 9, 2024 09:03
d6d7a18
to
8ce96ea
Compare
bangqipropel
temporarily deployed
to
unit-tests
October 9, 2024 09:03
— with
GitHub Actions
Inactive
bangqipropel
commented
Oct 9, 2024
bangqipropel
force-pushed
the
bangqipropel/RAG_controller
branch
from
October 10, 2024 23:47
8ce96ea
to
30b5ab8
Compare
bangqipropel
had a problem deploying
to
unit-tests
October 10, 2024 23:47
— with
GitHub Actions
Error
bangqipropel
force-pushed
the
bangqipropel/RAG_controller
branch
from
October 10, 2024 23:54
30b5ab8
to
7c9fc1f
Compare
bangqipropel
temporarily deployed
to
unit-tests
October 10, 2024 23:54
— with
GitHub Actions
Inactive
Signed-off-by: Bangqi Zhu <[email protected]>
bangqipropel
force-pushed
the
bangqipropel/RAG_controller
branch
from
October 18, 2024 23:38
7c9fc1f
to
bce9a9e
Compare
bangqipropel
had a problem deploying
to
unit-tests
October 18, 2024 23:38
— with
GitHub Actions
Error
Signed-off-by: Bangqi Zhu <[email protected]>
bangqipropel
force-pushed
the
bangqipropel/RAG_controller
branch
from
October 18, 2024 23:44
bce9a9e
to
6774c76
Compare
bangqipropel
temporarily deployed
to
unit-tests
October 18, 2024 23:44
— with
GitHub Actions
Inactive
bangqipropel
temporarily deployed
to
unit-tests
October 19, 2024 06:16
— with
GitHub Actions
Inactive
Fei-Guo
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
add Nodeclaim and Machine provision to RAG Engine controller
Requirements
Issue Fixed:
Notes for Reviewers: