Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Nodeclaim & Machine provision to RAG Engine controller #622

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

bangqipropel
Copy link
Collaborator

Reason for Change:
add Nodeclaim and Machine provision to RAG Engine controller

Requirements

  • added unit tests and e2e tests (if applicable).

Issue Fixed:

Notes for Reviewers:

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 31.52866% with 215 lines in your changes missing coverage. Please review.

Project coverage is 52.85%. Comparing base (5c30038) to head (ee088ea).
Report is 37 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controllers/ragengine_controller.go 29.78% 185 Missing and 13 partials ⚠️
pkg/controllers/workspace_controller.go 43.75% 9 Missing ⚠️
api/v1alpha1/zz_generated.deepcopy.go 0.00% 5 Missing ⚠️
pkg/controllers/ragengine_status.go 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   58.18%   52.85%   -5.34%     
==========================================
  Files          30       34       +4     
  Lines        2987     4221    +1234     
==========================================
+ Hits         1738     2231     +493     
- Misses       1149     1870     +721     
- Partials      100      120      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pkg/controllers/ragengine_status.go Outdated Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
pkg/controllers/ragengine_controller.go Show resolved Hide resolved
@Fei-Guo Fei-Guo merged commit 544df3f into main Oct 22, 2024
4 of 6 checks passed
@Fei-Guo Fei-Guo deleted the bangqipropel/RAG_controller branch October 22, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants