Add integration tests #72
Conversation
When guessing the reason for an insert conflict, the query needs to exactly match the configured database indexes. That means that the "name" and "networkName" queries need to both include "version" as well, otherwise we risk grabbing a row that isn't actually a conflict. Signed-off-by: Andrew Richardson <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
EnriqueL8
requested review from
peterbroadhurst,
nguyer,
awrichar and
shorsher
as code owners
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
Signed-off-by: Enrique Lacal <[email protected]>
| @@ -44,7 +43,8 @@ func (suite *TokensTestSuite) BeforeTest(suiteName, testName string) { | |||
| } | |||
|
|
|||
| func (suite *TokensTestSuite) AfterTest(suiteName, testName string) { | |||
| e2e.VerifyAllOperationsSucceeded(suite.T(), []*client.FireFlyClient{suite.testState.client1, suite.testState.client2}, suite.testState.startTime) | |||
| // Makes no sense if we expect failing operations - need to discuss as part of PR review | |||
| // e2e.VerifyAllOperationsSucceeded(suite.T(), []*client.FireFlyClient{suite.testState.client1, suite.testState.client2}, suite.testState.startTime) | |||
There was a problem hiding this comment.
@nguyer want to discuss this with you if possible, as part of 7781f8a you introduced a new error code and the operation doesn't succeed
I'm not sure if it's the case that we should remove this from the test and not expect all operations to succeed or that the code creates an operation too early before validating conflicts?
There was a problem hiding this comment.
Can you elaborate on why we would "expect" failing operations here? Up to this point, any case with a failing operation has actually been a bug, and I can't think of any cases at the moment where we would expect a failing operation.
Signed-off-by: Enrique Lacal <[email protected]>
| // Cannot delete published pools | ||
| suite.testState.client1.DeleteTokenPool(suite.T(), poolID, 409) | ||
| } | ||
| // func (suite *TokensTestSuite) TestE2ENonFungibleTokensSync() { |
There was a problem hiding this comment.
Sorry was just commented out whilst I was figuring out with test was failing and debugging it
No description provided.