Adding a note on reviewer eligibility #170
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Elliot J. Voris <[email protected]>
ElliotFriend
commented
Feb 1, 2022
| @@ -24,6 +24,11 @@ Can review bounties in exchange for rewards. | |||
|
|
|||
| Reviewers claim reviewable tasks and complete a review on the task assigning it a state of pass, fail or retry. Upon review completion the reviewer is awarded their share of the award amount as detailed by the bounty spec. | |||
|
|
|||
| #### Eligibility for Reviewers | |||
| In order to provide code reviews of the highest possible quality, anybody who wants to review bounties must be an established member within our [Discord server](https://discord.gg/jDjSQvTHTC). | |||
There was a problem hiding this comment.
Discord links apparently expire after a week by default. Would there be reasons not to include a link in the readme?
| #### Eligibility for Reviewers | ||
| In order to provide code reviews of the highest possible quality, anybody who wants to review bounties must be an established member within our [Discord server](https://discord.gg/jDjSQvTHTC). | ||
|
|
||
| We are also capping the number of reviewers per bounty at 2 (two). You can "claim" your spot as a reviewer with a comment on the relevant issue, but wait to do so until you've actually begun the review. |
There was a problem hiding this comment.
Is this a decent way to politely say "Don't be squatting on bounty reviews if you're not actually gonna do them well"?
…into reviewer-eligibility
…-bounties into reviewer-eligibility" Thought I was on `main` there... This reverts commit 3001024, reversing changes made to 7c531f9.
I'm using the words "substantial" and "actionable" here, although they might not be quite the correct fit. Signed-off-by: Elliot J. Voris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Elliot J. Voris [email protected]