Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the regex for the cycle tag less greed #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

live627
Copy link

@live627 live627 commented May 10, 2024

Fix #179

Resubmit #180

@live627
Copy link
Author

live627 commented May 10, 2024

what caused this


There was 1 error:

1) Liquid\Tag\TagIncludeTest::testIncludeTemplateFile
Liquid\Exception\NotFoundException: File not found: /home/runner/work/php-liquid/php-liquid/tests/Liquid/templates/./mypartial

@sanmai sanmai self-requested a review May 10, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

regex for the cycle tag gives wrong results
1 participant