build: development should not be copied in the first place [additiona…

…l tests, build docs]
kalisio · Mar 15, 2024 · b509627 · b509627
1 parent a22e4a9
commit b509627
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/app.Dockerfile b/app.Dockerfile
@@ -29,7 +29,7 @@ RUN \
   node /opt/kalisio/kli/index.js /opt/kalisio/kli.js --install && \
   node /opt/kalisio/kli/index.js /opt/kalisio/kli.js --link --link-folder /opt/kalisio/yarn-links && \
   cd /opt/kalisio/$APP && yarn pwa:build && \
-  rm -fR /opt/kalisio/development /opt/kalisio/kli /opt/kalisio/kli.js
+  rm -fR /opt/kalisio/kli /opt/kalisio/kli.js
 
 
 ## Copy to final container

diff --git a/app.Dockerfile.dockerignore b/app.Dockerfile.dockerignore
@@ -5,6 +5,7 @@
 # specific folders, we copy everyhting but the following :
 
 # Ignore all these
+development/*
 **/node_modules
 **/npm-debug.log
 **/*Dockerfile

diff --git a/scripts/build_app.sh b/scripts/build_app.sh
@@ -15,7 +15,7 @@ get_ci_build_number() {
     else
         case "$CI_ID" in
             github)
-                echo "$GITHUB_RUN_NUMBER-$GITHUB_RUN_ATTEMPT"
+                echo "$GITHUB_RUN_NUMBER.$GITHUB_RUN_ATTEMPT"
                 ;;
             gitlab)
                 echo "$CI_JOB_ID"