-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FEC-8212): support modular build process #265
Open
OrenMe
wants to merge
33
commits into
master
Choose a base branch
from
FEC-8212
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0e87bd1.
yairans
suggested changes
Aug 13, 2019
@@ -5,27 +5,156 @@ | |||
<meta name="viewport" content="width=device-width, initial-scale=1, maximum-scale=1.0, user-scalable=no"> | |||
<title>Title</title> | |||
<link rel="stylesheet" type="text/css" href="./style.css"/> | |||
<script src="./kaltura-ovp-player.js" type="text/javascript"></script> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
revert this file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
This PR will enable building the kaltura player as a modular bundle allowing to choose which packages are added to the bundle.
In order to allow this all dependencies were removed and are now subject to the application building the player to add them.
The kaltura player is now only the "convenience" wrapper project that allows doing complex operations with single methods(i.e. call loadMedia calls provider, parses and response, checks for errors, set config and evaluates tokens and then loads playkit).
This will allow to move the responsibility to choose dependencies in the bundler and remove unused packages from the payload, which will lead to smaller bundle and faster load times etc.
This will also enable us to hook the project to our generic CI/CD pipe and deploy passing builds on the fly to the staging area.
Need to:
CheckLists