Add capabilities to control the Kaltura button in HTML editors #379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @estevebadia, |
|
Hi, Just signed the CLA |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds capabilities to TinyMCE and Atto plugins so that the Kaltura button is shown only for those users with required capability. By default, the capability is enabled in all role archetypes from student to manager so there shouldn't be any backwards compatibility issues.
Concretely:
/lib/editor/tinymce/plugins/kalturamediatinymce/kalturamedia:insertcapability. The kaltura button is shown only for users with that capability./lib/editor/atto/plugins/kalturamediaatto/kalturamedia:insertcapability. The kaltura button is shown only for users with that capability.Note that this PR implements the same feature than #356 but this one also adds the symmetric feature for tinymce plugin.
Are you interested in this feature?
Note: I'm contributing to this repo for the first time, please guide me on the way to proceed!