Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix optional parameter declared before required parameter. #433

Open
wants to merge 1 commit into
base: MOODLE_404_DEV
Choose a base branch
from
Open

Fix optional parameter declared before required parameter. #433

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mod/kalvidassign/grade_submissions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@
}
}

$renderer->display_submissions_table($cm, $data->group_filter, $data->filter, $data->perpage, $data->quickgrade, $tifirst, $tilast, $page);
$renderer->display_submissions_table($cm, $data->perpage, $data->group_filter, $data->filter, $data->quickgrade, $tifirst, $tilast, $page);

$prefform->set_data($data);
$prefform->display();
Expand Down
5 changes: 3 additions & 2 deletions mod/kalvidassign/renderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -706,17 +706,18 @@ public function display_instructor_buttons($cm, $userid) {

/**
* This function returns HTML markup to render a the submissions table
*
* @param object $cm A course module object.
* @param int $perpage The number of submissions to display on a page.
* @param int $groupfilter The group id to filter against.
* @param string $filter Filter users who have submitted, submitted and graded or everyone.
* @param int $perpage The number of submissions to display on a page.
* @param bool $quickgrade True if the quick grade table needs to be rendered, otherwsie false.
* @param string $tifirst The first initial of the first name.
* @param string $tilast The first initial of the last name.
* @param int $page The current page to render.
* @return string Returns HTML markup.
*/
public function display_submissions_table($cm, $groupfilter = 0, $filter = 'all', $perpage, $quickgrade = false, $tifirst = '', $tilast = '', $page = 0) {
public function display_submissions_table($cm, $perpage, $groupfilter = 0, $filter = 'all', $quickgrade = false, $tifirst = '', $tilast = '', $page = 0) {

global $DB, $COURSE, $USER;

Expand Down