Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflected XSS Vulnerability on rss.php #4300

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

frostb1ten
Copy link

Fix for a Reflected XSS vulnerability. Attackers can add the X-Forwarded-Host header to inject XSS payloads.

X-Forwarded-Host: <script>alert(document.cookie)</script>

This mitigation prevents X-Forwarded-Host from being modified.

Fix for a Reflected XSS vulnerability. Attackers can add the X-Forwarded-Host header to inject XSS payloads.

 X-Forwarded-Host: <script>alert(document.cookie)</script>

This mitigation prevents  X-Forwarded-Host from being modified.
@kaltura-hooks
Copy link

Hi @frostb1ten,
Thank you for contributing this pull request!
Please sign the Kaltura CLA so we can review and merge your contribution.
Learn more at http://bit.ly/KalturaContrib

@frostb1ten
Copy link
Author

CLA completed. Thank you!

@frostb1ten frostb1ten changed the title Update rss.php Reflected XSS Vulnerability on rss.php Sep 22, 2022
Copy link
Author

@frostb1ten frostb1ten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$baseUrl later on is displayed back at:

<link><?php echo $baseUrl ?></link>

Changing to SERVER_NAME prevents attackers from modifying the host via x-forwarded-host.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants