Check libavcodec version for AV1 codec definition #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kalturaguy
approved these changes
Nov 23, 2023
erankor
reviewed
Nov 23, 2023
vod/thumb/thumb_grabber.c
Outdated
| @@ -55,7 +55,9 @@ static codec_id_mapping_t codec_mappings[] = { | |||
| { VOD_CODEC_ID_HEVC, AV_CODEC_ID_H265, "h265" }, | |||
| { VOD_CODEC_ID_VP8, AV_CODEC_ID_VP8, "vp8" }, | |||
| { VOD_CODEC_ID_VP9, AV_CODEC_ID_VP9, "vp9" }, | |||
| #if LIBAVFORMAT_VERSION_INT >= AV_VERSION_INT(60, 16, 100) | |||
There was a problem hiding this comment.
need to check libavcodec version, not libavformat, this module doesn't use libavformat...
I think it should be LIBAVCODEC_VERSION >= AV_VERSION_INT(57, 25, 0)
the codec id constant was added here - FFmpeg/FFmpeg@d42809f
There was a problem hiding this comment.
Updated to libavcodec with 57,89,100
david-winder-kaltura
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #1461, compilation is fail with old ffmpeg. the AV1 codec is only supporting from libformat 60.16.100 (ffmpeg 6) - FFmpeg/FFmpeg@7a5e9a6