Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Automation Test Dependency Libs #479

Merged
merged 6 commits into from
May 8, 2024
Merged

update Automation Test Dependency Libs #479

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3e2c3d2
update Automation Test Dependency Libs
imberezin May 8, 2024
be064cb
update timeout to 20
imberezin May 8, 2024
df4b7b4
Update pr.yml
imberezin May 8, 2024
ad3a434
Update pr.yml
imberezin May 8, 2024
96d2684
update also remove observer name
imberezin May 8, 2024
6672c91
Update pr.yml
imberezin May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/pr.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,8 @@ jobs:
name: "tvOS"
scheme: "PlayKit-Package"
steps:
- name: Force Xcode 15
run: sudo xcode-select -switch /Applications/Xcode_15.2.app
- uses: actions/checkout@v4
- name: ${{ matrix.name }}
run: set -o pipefail && env NSUnbufferedIO=YES xcodebuild -scheme "${{ matrix.scheme }}" -destination "${{ matrix.destination }}" clean test | xcpretty
Expand Down
2 changes: 1 addition & 1 deletion Classes/Player/AVPlayerEngine/AVPlayerEngine+Observation.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ extension AVPlayerEngine {

NotificationCenter.default.removeObserver(self, name: .AVPlayerItemFailedToPlayToEndTime, object: self.currentItem)
NotificationCenter.default.removeObserver(self, name: .AVPlayerItemDidPlayToEndTime, object: self.currentItem)
NotificationCenter.default.removeObserver(self, name: .AVPlayerItemNewAccessLogEntry, object: self.currentItem)
NotificationCenter.default.removeObserver(self, name: AVPlayerItem.newAccessLogEntryNotification, object: self.currentItem)
NotificationCenter.default.removeObserver(self, name: .AVPlayerItemNewErrorLogEntry, object: self.currentItem)
NotificationCenter.default.removeObserver(self, name: .AVPlayerItemPlaybackStalled, object: self.currentItem)
NotificationCenter.default.removeObserver(self, name: Notification.Name(kCMTimebaseNotification_EffectiveRateChanged as String), object: nil)
Expand Down
8 changes: 4 additions & 4 deletions Example/Tests/Basic/MessageBusTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class MessageBusTest: XCTestCase {

self.player.play()

waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

func testPlayerPlayEventsFlow() {
Expand All @@ -62,7 +62,7 @@ class MessageBusTest: XCTestCase {

self.player.play()

waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

func testPlayerPauseEventsFlow() {
Expand All @@ -80,7 +80,7 @@ class MessageBusTest: XCTestCase {

self.player.play()

waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

func testPlayerSeekEventsFlow() {
Expand Down Expand Up @@ -110,6 +110,6 @@ class MessageBusTest: XCTestCase {

self.player.play()

waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}
}
6 changes: 3 additions & 3 deletions Example/Tests/Basic/PlayerControllerTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class PlayerControllerTest: XCTestCase {
XCTFail()
}
}
waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

func testPauseCommand() {
Expand All @@ -55,7 +55,7 @@ class PlayerControllerTest: XCTestCase {
self.player.addObserver(self, events: [PlayerEvent.playing]) { [weak self] event in
self?.player.pause()
}
waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}


Expand All @@ -78,7 +78,7 @@ class PlayerControllerTest: XCTestCase {
}
}
}
waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

/// Test a guard mechanism that prevents receiving pause events after ended event.
Expand Down
4 changes: 2 additions & 2 deletions Example/Tests/Basic/TracksTest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class TracksTest: XCTestCase {
}
}

waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

func testSelectTrack() {
Expand All @@ -66,7 +66,7 @@ class TracksTest: XCTestCase {
}
}

waitForExpectations(timeout: 10.0) { (_) -> Void in}
waitForExpectations(timeout: 20.0) { (_) -> Void in}
}

override func tearDown() {
Expand Down
8 changes: 4 additions & 4 deletions Package.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import PackageDescription

let package = Package(
name: "PlayKit",
platforms: [.iOS(.v11),
.tvOS(.v11)],
platforms: [.iOS(.v14),
.tvOS(.v14)],
products: [.library(name: "PlayKit",
targets: ["PlayKit"]),
.library(name: "AnalyticsCommon",
Expand All @@ -19,8 +19,8 @@ let package = Package(
.package(name: "KalturaNetKit",
url: "https://github.com/kaltura/netkit-ios.git",
.upToNextMinor(from: "1.7.0")),
.package(url: "https://github.com/Quick/Quick.git", .upToNextMajor(from: "5.0.0")),
.package(url: "https://github.com/Quick/Nimble.git", .upToNextMajor(from: "9.0.0")),
.package(url: "https://github.com/Quick/Quick.git", .upToNextMajor(from: "7.5.0")),
.package(url: "https://github.com/Quick/Nimble.git", .upToNextMajor(from: "13.3.0")),
],
targets: [.target(name: "PlayKit",
dependencies:
Expand Down