fix(ADA-1359): Make scrollbar visible all the time #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinStoicaK
requested review from
semarche-kaltura,
lianbenjamin and
SivanA-Kaltura
Tzipi-kaltura
changed the title
semarche-kaltura
requested changes
Aug 14, 2024
| } | ||
| }, []); | ||
|
|
||
| const handleFocus = useCallback(() => {}, []); |
There was a problem hiding this comment.
if that's only noop methods, why keep them? Can we remove handleFocus, handleBlur and handleKeyDown methods?
|
@valentinStoicaK please change the version of cypress in package.json to 13.13.1, run yarn install, and commit package.json and yarn.lock. this should solve the firefox timeout that's failing the tests. |
|
@SivanA-Kaltura Done! |
semarche-kaltura
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause:
PR description:
PS: I don't have the possibility of testing it on Safari and QA informed me that the scrollbar was not visible at all on safari before the fix;