chore(FEC-13175): Upgrade Webpack deps and fix source-maps #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonathanTGold
requested review from
giladna,
lianbenjamin,
Yuvalke,
SivanA-Kaltura and
semarche-kaltura
SivanA-Kaltura
requested changes
May 23, 2023
| } | ||
| }; | ||
| const webpackConfig = require('./webpack.config')('development', {mode: 'development'}); | ||
| delete webpackConfig.entry; |
| @@ -0,0 +1,5 @@ | |||
| { | |||
There was a problem hiding this comment.
why do you need a separate package.json for each ?
| const webpack = require('webpack'); | ||
| const path = require('path'); | ||
| const packageData = require('./package.json'); | ||
| const TerserPlugin = require('terser-webpack-plugin'); |
There was a problem hiding this comment.
what does terser provide ?
| logLevel: config.LOG_INFO, | ||
| autoWatch: false, | ||
| browsers: ['ChromeHeadless'], | ||
| singleRun: true, |
There was a problem hiding this comment.
does test:watch still work when singleRun is true in the config file ?
SivanA-Kaltura
requested changes
May 23, 2023
| "build": "webpack --mode production", | ||
| "dev": "webpack-dev-server --mode development", | ||
| "watch": "webpack --progress --colors --watch --mode development", | ||
| "build:dev": "webpack serve --open --mode=development", |
There was a problem hiding this comment.
doesn't the devops script count on a "build" task existing ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Changes
The updated Babel configuration for the webpage aims to remove support for Internet Explorer (IE), reduce the bundle size, and improve code quality. The changes can be described as follows:
The benefits of this updated configuration are:
By updating the Babel configuration in this way, you not only remove IE support and reduce bundle size but also ensure code reliability and enhance code quality by adhering to strict ECMAScript standards. This helps optimize the performance of your webpage while promoting maintainable and reliable code.
Bundle size effects:
Before:
playkit-ott-provider.js 31.3 KiB
playkit-ovp-provider.js 47.7 KiB
playkit-analytics-service.js 10.5 KiB
playkit-bookmark-service.js 9.17 KiB
playkit-stats-service.js 9.82 KiB
After:
asset playkit-ovp-provider.js 35.7 KiB
asset playkit-ott-provider.js 22.2 KiB
asset playkit-analytics-service.js 7.81 KiB
asset playkit-stats-service.js 7.16 KiB
asset playkit-bookmark-service.js 6.76 KiB
solves FEC-13175
CheckLists