Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SUP-40028): The playlist player freezes during the playback #728

Closed
wants to merge 1 commit into from

Conversation

Tzipi-kaltura
Copy link
Contributor

@Tzipi-kaltura Tzipi-kaltura commented Nov 13, 2023

Description of the Changes

issue:
the playlist player freezes when moving to youtube entry (when timeline plugin is loaded).

solution:
youtube doesn't have getThumbnail function, adding validation.

solves SUP-40028

CheckLists

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • test are passing in local environment
  • Travis tests are passing (or test results are not worse than on master branch :))
  • Docs have been updated

Copy link
Contributor

@JonathanTGold JonathanTGold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect
YouTube engine should implement the IEngine interface (can simply return null)
And will address the root of the issue instead of adding a patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants