Null objects task #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// Interface for null checker used in NullCounter | ||
| /// </summary> | ||
| /// <typeparam name="T">Type of which will be elements you check for null</typeparam> | ||
| public interface INullChecker<T> |
There was a problem hiding this comment.
Suggested change
| public interface INullChecker<T> | |
| public interface INullChecker<in T> |
| @@ -0,0 +1,15 @@ | |||
| namespace Zachet; | |||
There was a problem hiding this comment.
Пространство имён должно совпадать с именем проекта
Comment on lines
+13
to
+16
| public bool IsNull(int value) | ||
| { | ||
| return value == 0; | ||
| } |
There was a problem hiding this comment.
Suggested change
| public bool IsNull(int value) | |
| { | |
| return value == 0; | |
| } | |
| public bool IsNull(int value) | |
| => value == 0; |
| /// <param name="list">Collection implementing IEnumerable (to iterate through it)</param> | ||
| /// <param name="nullChecker">Object which can check if element of T type is null</param> | ||
| /// <returns>Count of null objects</returns> | ||
| public static int CountNullObjects<T>(IEnumerable<T> list, INullChecker<T> nullChecker) |
There was a problem hiding this comment.
Без вариантности тут слишком жёсткое ограничение на типы
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
| public void ListWithNullsTest() | ||
| { | ||
| Assert.That(NullCounter.CountNullObjects<int>(listWithNulls, intNullChecker), Is.EqualTo(3)); | ||
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.