refactor: pre-pano chores #539
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -0,0 +1,8 @@ | |||
| /* | |||
There was a problem hiding this comment.
since we are using planet scale is this needed anymore ? i thought they are just using push on all changes so migrations are not needed. I might be wrong, don't know planet scale that much
There was a problem hiding this comment.
yeah this is mainly for local dev
we need to figure out a way to scale the folder structure
use createPrismaLoader from @kampus/gql-utils
| @@ -1,13 +1,39 @@ | |||
| import type { CodegenConfig } from "@graphql-codegen/cli"; | |||
|
|
|||
| const scalars = { Date: "string", DateTime: "string" }; | |||
There was a problem hiding this comment.
Would "https://www.npmjs.com/package/graphql-scalars" help us with these ?
| import { parse, stringify } from "@kampus/gql-utils/global-id"; | ||
| import { type User } from "@kampus/prisma"; | ||
| import { assertNever } from "@kampus/std"; | ||
| import { type Dictionary } from "@kampus/std/dictionary"; |
There was a problem hiding this comment.
should this type be exported from "@kampus/std" ?
There was a problem hiding this comment.
i thouht about it but since @kampus/std itself is gonna be lots of helpers/utils/modules (at least that's how i envision it), it's actually an umbrella package. so namespacing it to one level deeper, "/dictionary" for this example, should help us avoiding the namespace collisions. Think of it as importing from lodash/groupBy instead of lodash. Also helps the app to "tree shake" better (not even sure if it's the right term 😅 )
I've changed the SozlukTerms query args in #539 but forgot to change query we made in the sozluk query term page. This also fixes the most stupidest npm bug i've ever encountered, i won't even try to explain it but just know that it's so stupid and i don't even know how we as an industry survive.
Things that needs to be done before we can move onto #510