Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create @kampus/std package #542

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Create @kampus/std package #542

merged 3 commits into from
Jul 25, 2023

Conversation

arabacibahadir
Copy link
Member

@arabacibahadir arabacibahadir commented Jul 25, 2023

Set of ts/js utilities/functions that can we use in every other workspace.

@arabacibahadir arabacibahadir requested a review from a team as a code owner July 25, 2023 10:10
@vercel
Copy link

vercel bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
kampus-gql ⬜️ Ignored (Inspect) Jul 25, 2023 9:59pm
kampus-next ⬜️ Ignored (Inspect) Jul 25, 2023 9:59pm
kampus-pasaport ⬜️ Ignored (Inspect) Jul 25, 2023 9:59pm
kampus-ui ⬜️ Ignored (Inspect) Jul 25, 2023 9:59pm

@vercel
Copy link

vercel bot commented Jul 25, 2023

@arabacibahadir is attempting to deploy a commit to the kamp-us Team on Vercel.

A member of the Team first needs to authorize it.

@Ketcap
Copy link
Contributor

Ketcap commented Jul 25, 2023

@arabacibahadir thanks for the PR i think we need to issue for this to see why and what needs to be done for this. If the task is not there please open it and check with @usirin with the details.

Quick review: naming as "husky" does not feel like this is utilities but this is a husky package https://github.com/typicode/husky

@usirin
Copy link
Member

usirin commented Jul 25, 2023

I've asked from @arabacibahadir to do this in this exact way with this exact package name 😅

Our bad, we should've opened an issue. We talked through this on my twitch stream.

@Ketcap
Copy link
Contributor

Ketcap commented Jul 25, 2023

I've asked from @arabacibahadir to do this in this exact way with this exact package name 😅

Our bad, we should've opened an issue. We talked through this on my twitch stream.

No worries let's open an issue to put needs

@usirin
Copy link
Member

usirin commented Jul 25, 2023

@Ketcap you're right, using husky name can cause confusions. let's go with a boring, easy to understand package name: @kampus/std. Standard library for kampus projects.

packages/std/README.md Outdated Show resolved Hide resolved
@usirin usirin changed the title Create @kampus/husky package Create @kampus/std package Jul 25, 2023
Copy link
Member

@usirin usirin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@usirin usirin merged commit a2e785f into kamp-us:dev Jul 25, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants