Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support hubot api #438

Closed
wants to merge 9 commits into from
Closed

Support hubot api #438

wants to merge 9 commits into from

Conversation

miurahr
Copy link
Contributor

@miurahr miurahr commented Apr 21, 2015

#393 is incomplete support for hubot master branch. It produce 404 error for /me? /channels? api access.

because API with auth_token is considered as unauthorized access in routes.rb.

Here is additional fix to #393 PR.
This PR is tested against hubot master.

@miurahr
Copy link
Contributor Author

miurahr commented Apr 29, 2015

In previous PR , I just put API related resources out of constraints (authenticated :user).
Additional https://github.com/miurahr/kandan/commit/e42d51a71c0aad0ed45aa2de2112236efac51f75 aim to explicitly authenticate as user or token.

Because it is not working for channels:activities nested resource, put these out of authorized_or_have_token constraints. welcome suggestions!

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.64%) to 69.21% when pulling e42d51a on miurahr:support_hubot_api into 4a7d912 on kandanapp:master.

@miurahr
Copy link
Contributor Author

miurahr commented May 10, 2015

Due to a failure of Travis CI test, I've reverted last modifications. It will be tried again in a separate PR.

@miurahr
Copy link
Contributor Author

miurahr commented Jul 15, 2015

Drop here and I'd like to submit cleaned PR agian.

@miurahr miurahr closed this Jul 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants