feature i18n switcher #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: warjiang <[email protected]>
1. remove unused console.log 2. remove unused i18next plugin 3. refactor init render flow 4. add switch lang logic and icon for zh/cn Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
- translation for zh-CN/en-US(by i18n-cli) - add lang switcher on the navigation bar Signed-off-by: warjiang <[email protected]>
Signed-off-by: warjiang <[email protected]>
- husky for config git hooks - prettier for consistent code style Signed-off-by: warjiang <[email protected]>
karmada-bot
added
the
kind/feature
karmada-bot
added
the
size/XXL
- custom eslint rules in packages dir - lint code in dashboard Signed-off-by: warjiang <[email protected]>
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
karmada-bot
added
the
approved
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
The
prettierwill format a bunch of code, but no changes for code logic, it's no need to review the logic line by line.Does this PR introduce a user-facing change?: