Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Karmada config page #79

Closed
wants to merge 0 commits into from
Closed

Conversation

axif0
Copy link
Contributor

@axif0 axif0 commented Aug 9, 2024

What type of PR is this?
/kind api-change
/kind design

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #75

Special notes for your reviewer:

@warjiang Can you tell me about edit the components' raw manifest , scale in and out the components and app description ?
And tese are the api call from backend

/config/running-apps
/config/pods/{running-apps}
/config/log/:{pod_name}
/config/restart/:{pod_name}
/cluster/status/:{pod_name}
/config/reinstall/:{pod_name}

Please suggest me if i'm in the right path.

Does this PR introduce a user-facing change?:

  • Check Status

image

  • logs

image

  • Reinstall

image

-Restart
image

@karmada-bot karmada-bot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. labels Aug 9, 2024
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 9, 2024
@axif0 axif0 changed the title Karmada config page Signed-off-by: axif <[email protected]> Karmada config page Aug 9, 2024
@axif0 axif0 force-pushed the KarmadaConfigPage branch from d626290 to 2ee9663 Compare August 9, 2024 21:15
@karmada-bot karmada-bot removed the do-not-merge/contains-merge-commits Indicates a PR which contains merge commits. label Aug 9, 2024
@warjiang
Copy link
Contributor

@axif0 Thanks for your great work, sorry late for the reply,

  • edit the components' raw manifest : is just like edit the components manifest, in our project, we use monaco editor to edit the yaml, maybe you can reuse the component
    what we expected is like edit yaml in kubernetes dashboard:
    image
  • scale in and out the components: is used to scale out the replica of deployment

@warjiang
Copy link
Contributor

This will be a big PR, and we need to make a more detailed document about the feature, including design、 api document, you can refer the link: https://github.com/karmada-io/karmada/blob/master/docs/proposals/proposal-template/proposal-template.md.
Don't worry, I'll cooperate with you to finish this feature.

@axif0 axif0 force-pushed the KarmadaConfigPage branch from 015e197 to 0a0b1bd Compare August 12, 2024 20:27
@axif0 axif0 closed this Aug 18, 2024
@axif0 axif0 force-pushed the KarmadaConfigPage branch from 0a0b1bd to 8777d59 Compare August 18, 2024 13:03
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/design Categorizes issue or PR as related to design. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Configuration of karmada components.
3 participants