Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lfx-mentorship-2024-September-November] Enhance the test coverage for the Karmada search, operator, and webhook components. #5236

Closed
XiShanYongYe-Chang opened this issue Jul 23, 2024 · 18 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@XiShanYongYe-Chang
Copy link
Member

CNCF LFX mentorship
https://github.com/cncf/mentoring/blob/main/programs/lfx-mentorship/2024/03-Sep-Nov/README.md

Mentor: @XiShanYongYe-Chang

What would you like to be added:

Karmada would like to improve the UT coverage of the code to better maintain the quality of the code and reduce the introduction of defects.

Increase the UT coverage rate to 50% to 60% (currently, the UT coverage rate is 28.26% ).

The entire Karmada repository is a bit large for one project, so we will split it into two projects. The current project needs to improve UT coverage except for the following directory:

pkg/controllers
pkg/dependenciesdistributor
pkg/descheduler
pkg/detector
pkg/estimator
pkg/scheduler
pkg/resourceinterpreter
pkg/util

This, together with #5235, constitutes our enhanced UT task.

I hope that the students who apply for this project can give the UT coverage rate of each directory plan to achieve, we will move towards these specific goals.

Why is this needed:

@XiShanYongYe-Chang XiShanYongYe-Chang added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 23, 2024
@varshith257
Copy link
Contributor

@XiShanYongYe-Chang Any pretest for this project and recommended communication channels to connect

@XiShanYongYe-Chang
Copy link
Member Author

Hi @varshith257 The project has not been reported. The progress will be synchronized to the current issue.

@XiShanYongYe-Chang XiShanYongYe-Chang changed the title [lfx-mentorship-2024-September-November] Enhance Karmada testing coverage except controller-manger and schedule [lfx-mentorship-2024-September-November] Enhance the test coverage for the Karmada search, operator, and webhook components. Jul 30, 2024
@mohamedawnallah
Copy link
Contributor

mohamedawnallah commented Aug 1, 2024

Hi @XiShanYongYe-Chang I'm interested in this project under LFX Mentorship. I've submitted a PR to fully test federatedresourcequota webhook so I could get more familiar with these ones. I'd love to receive any feedback thanks! 🙏

@XiShanYongYe-Chang
Copy link
Member Author

Thanks @mohamedawnallah
/assign

@yashpandey06
Copy link

yashpandey06 commented Aug 1, 2024

@XiShanYongYe-Chang Hey, great project! I'm interested in contributing to it. under LFX Mentorship I have experience in writing test cases and look forward to making valuable contributions. Looking forward to collaborating with you all!

@XiShanYongYe-Chang
Copy link
Member Author

We look forward to every enthusiastic partner to join the Karmada community. ^-^

/unassign

@anujagrawal699
Copy link
Contributor

@XiShanYongYe-Chang I completed the LFX tasks and looking for some pre-tests. I have experience in writing unit tests and made patches of implementing unit tests in Wikimedia foundation core project.

@anujagrawal699
Copy link
Contributor

@XiShanYongYe-Chang Here it is.

@XiShanYongYe-Chang
Copy link
Member Author

Just for reference: We can get the code coverage of different files under the current master branch from here.

@yashpandey06
Copy link

Just for reference: We can get the code coverage of different files under the current master branch from here.

Really helped 😃

@836hardik-agrawal
Copy link

Hi @XiShanYongYe-Chang I am interested in this project. Currently working on multiclusteringress webhook so to get familiarity.
Looking forward for contributions!

@XiShanYongYe-Chang
Copy link
Member Author

Hello everyone, thank you all very much for your active contributions, the Karmada community warmly welcomes everyone to participate in open-source contributions. You can see that the number of our LFX project spots is less than the number of applicants, which means that the final number of selected participants will be quite small. However, I hope everyone can understand that this is not because you are not good enough. On the contrary, being able to actively participate in open-source contributions, you are all very excellent. Therefore, even if you are not selected for this LFX event in the end, please don't be disappointed. There will still be LFX events to apply for in the future, and I hope everyone can continue to participate and pay attention to the Karmada community.

@yashpandey06
Copy link

Hello everyone, thank you all very much for your active contributions, the Karmada community warmly welcomes everyone to participate in open-source contributions. You can see that the number of our LFX project spots is less than the number of applicants, which means that the final number of selected participants will be quite small. However, I hope everyone can understand that this is not because you are not good enough. On the contrary, being able to actively participate in open-source contributions, you are all very excellent. Therefore, even if you are not selected for this LFX event in the end, please don't be disappointed. There will still be LFX events to apply for in the future, and I hope everyone can continue to participate and pay attention to the Karmada community.

Fingers crossed 🤞..let's hope for good .

@XiShanYongYe-Chang
Copy link
Member Author

Hi @mohamedawnallah the lfx project is ready to start. Do you have time to make a detailed project plan for the project and submit an issue for task tracking?

@yashpandey06
Copy link

Best of luck fellows @anujagrawal699 @mohamedawnallah

@mohamedawnallah
Copy link
Contributor

Hi @XiShanYongYe-Chang, That is great! I would submit a tracking issue today for the project!

@XiShanYongYe-Chang
Copy link
Member Author

This task will be tracked by #5491
Thanks all.
/close

@karmada-bot
Copy link
Collaborator

@XiShanYongYe-Chang: Closing this issue.

In response to this:

This task will be tracked by #5491
Thanks all.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

7 participants