Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Umbrella] format the code in karmada-dashboard repo to meet golangci-lint #6078

Open
10 tasks
chaosi-zju opened this issue Jan 23, 2025 · 6 comments
Open
10 tasks
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@chaosi-zju
Copy link
Member

chaosi-zju commented Jan 23, 2025

What would you like to be added:

format the code in karmada-dashboard repo to meet golangci-lint

Why is this needed:

597 issues:
* errcheck: 6
* gci: 249
* gocyclo: 2
* gofmt: 4
* goimports: 14
* gosec: 4
* gosimple: 5
* govet: 1
* ineffassign: 5
* misspell: 2
* revive: 267
* staticcheck: 2
* unused: 8
* whitespace: 28

for revive lint (267):
  * blank-imports 2
  * empty-block 1
  * exported 150
  * indent-error-flow 2
  * receiver-naming 27
  * superfluous-else 1
  * unused-parameter 8
  * var-declaration 3
  * var-naming 14
@chaosi-zju chaosi-zju added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 23, 2025
@chaosi-zju
Copy link
Member Author

@warjiang which would you like to pick

@chaosi-zju
Copy link
Member Author

/help

@karmada-bot
Copy link
Collaborator

@chaosi-zju:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@karmada-bot karmada-bot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 23, 2025
@warjiang
Copy link
Contributor

@warjiang which would you like to pick

I would like to pick whitespace for a try. After whitespace lint problems are resolved, I'll try more tasks~

@warjiang
Copy link
Contributor

@chaosi-zju No permission to edit the issue,
for whitespace => karmada-io/dashboard#180

@RainbowMango
Copy link
Member

Issue author manages issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
Status: No status
Development

No branches or pull requests

4 participants