Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

format code about goimports and gci #178

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

chaosi-zju
Copy link
Member

@chaosi-zju chaosi-zju commented Jan 22, 2025

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

format code about goimports and gci

Which issue(s) this PR fixes:

Fixes part of karmada-io/karmada#6078

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 22, 2025
@karmada-bot karmada-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 22, 2025
@chaosi-zju
Copy link
Member Author

@warjiang could you help reviewing this PR?

@warjiang
Copy link
Contributor

/assign

@warjiang
Copy link
Contributor

for cmd/api/app/routes/clusterpropagationpolicy/handler.go
why these two imports missing:
image

same for cmd/api/app/routes/clusteroverridepolicy/handler.go

@warjiang
Copy link
Contributor

I'm very looking forward to this ci feature 👍 . I run hack/verify-staticcheck.sh locally, should I fix these problems and collabrate the PR with you @chaosi-zju

@warjiang
Copy link
Contributor

hack/verify-staticcheck.sh

hack/verify-staticcheck.sh lack of execuate permission

@chaosi-zju
Copy link
Member Author

chaosi-zju commented Jan 22, 2025

I'm very looking forward to this ci feature 👍 . I run hack/verify-staticcheck.sh locally, should I fix these problems and collabrate the PR with you @chaosi-zju

Ok, I will create a issue, and list the subtask and invite friends to participate in.

I now repair this PR first, split this PR is not that easy, haha~

@chaosi-zju chaosi-zju changed the title format code including optimize imports and remove unused object format code about goimports and gci Jan 22, 2025
@chaosi-zju
Copy link
Member Author

the check script reports:

Running error: context loading failed: no go files to analyze: running `go mod tidy` may solve the problem

I will fix this error tomorrow~

@chaosi-zju
Copy link
Member Author

ready to review

@warjiang
Copy link
Contributor

ready to review

I'll check it asap.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
This PR mostly focuses on fixing government issues and sorting the import group.

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2025
@warjiang
Copy link
Contributor

/lgtm
/approve
thanks~

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: warjiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 23, 2025
@karmada-bot karmada-bot merged commit ef734e5 into karmada-io:main Jan 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants