-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
format code about goimports and gci #178
Conversation
@warjiang could you help reviewing this PR? |
/assign |
d7173d6
to
1928690
Compare
I'm very looking forward to this ci feature 👍 . I run hack/verify-staticcheck.sh locally, should I fix these problems and collabrate the PR with you @chaosi-zju |
|
Ok, I will create a issue, and list the subtask and invite friends to participate in. I now repair this PR first, split this PR is not that easy, haha~ |
1928690
to
ac91350
Compare
5c98e10
to
5581849
Compare
the check script reports:
I will fix this error tomorrow~ |
5581849
to
911bf35
Compare
Signed-off-by: chaosi-zju <[email protected]>
911bf35
to
fa4f12a
Compare
ready to review |
I'll check it asap. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
This PR mostly focuses on fixing government issues and sorting the import group.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: warjiang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
format code about goimports and gci
Which issue(s) this PR fixes:
Fixes part of karmada-io/karmada#6078
Special notes for your reviewer:
Does this PR introduce a user-facing change?: