Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: helm podDisruptionBudget for controller-manager #4188

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Oct 27, 2023

What type of PR is this?
/kind bug

What this PR does / why we need it:

before

---
# Source: karmada/templates/karmada-controller-manager.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: karmada-controller-manager
  namespace: karmada-system
  labels:

    app: karmada-controller-manager
spec:
  selector:
    matchLabels:

      app: karmada-controller-manager

  maxUnavailable: 20%---  # <--- this is the issue
---

after:

---
# Source: karmada/templates/karmada-controller-manager.yaml
apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: karmada-controller-manager
  namespace: karmada-system
  labels:

    app: karmada-controller-manager
spec:
  selector:
    matchLabels:

      app: karmada-controller-manager

  maxUnavailable: 20%
---

Which issue(s) this PR fixes:
N/A

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fixed helm render of podDisruptionBudget in controller-manager

@karmada-bot karmada-bot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 27, 2023
@karmada-bot karmada-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (761e22e) 52.83% compared to head (5ef785d) 52.85%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4188      +/-   ##
==========================================
+ Coverage   52.83%   52.85%   +0.01%     
==========================================
  Files         239      239              
  Lines       23559    23559              
==========================================
+ Hits        12448    12451       +3     
+ Misses      10434    10432       -2     
+ Partials      677      676       -1     
Flag Coverage Δ
unittests 52.85% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member

/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2023
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2023
@karmada-bot karmada-bot merged commit 961aa69 into karmada-io:master Oct 30, 2023
12 checks passed
@a7i a7i deleted the helm-fix-pdb-controller-manager branch October 30, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants