Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github action yaml format #4571

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

liangyuanpeng
Copy link
Contributor

@liangyuanpeng liangyuanpeng commented Jan 22, 2024

What type of PR is this?
/kind cleanup

What this PR does / why we need it:

This workflow always failed:

[Invalid workflow file: .github/workflows/ci-schedule.yml#L45](https://github.com/karmada-io/karmada/actions/runs/7602918824/workflow)
The workflow is not valid. .github/workflows/ci-schedule.yml (Line: 45, Col: 9): Unexpected value 'max_attempts' .github/workflows/ci-schedule.yml (Line: 46, Col: 9): Unexpected value 'timeout_minutes'

So this pr is working for fix format error when introducing nick-fields/retry.

/assign @RainbowMango @jwcesign

Here is the test of trigger : https://github.com/karmada-io/karmada/actions/runs/7605882134

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jan 22, 2024
@karmada-bot karmada-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f054313) 51.89% compared to head (cb498a8) 51.88%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4571      +/-   ##
==========================================
- Coverage   51.89%   51.88%   -0.02%     
==========================================
  Files         246      246              
  Lines       24328    24328              
==========================================
- Hits        12626    12622       -4     
- Misses      11016    11019       +3     
- Partials      686      687       +1     
Flag Coverage Δ
unittests 51.88% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
Great thanks @liangyuanpeng .

Leave LGTM to @jwcesign

@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 22, 2024
@jwcesign
Copy link
Member

Nice catch!
/lgtm

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 22, 2024
@karmada-bot karmada-bot merged commit 4ddc87a into karmada-io:master Jan 22, 2024
12 checks passed
@pulsarsigs-bot pulsarsigs-bot deleted the fix_format_ghaction branch January 22, 2024 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants