Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 100% test coverage for matcher, shadow, and names.go in pkg/util #5339

Merged

Conversation

NishantBansal2003
Copy link
Contributor

What type of PR is this?
/kind feature
/kind failing-test

What this PR does / why we need it:
The test case coverage for interpreter/matcher.go, overridemanager/shadow.go and names/names.go has been increased to 100%.

Which issue(s) this PR fixes:
Ref #5235

Special notes for your reviewer:
To verify the changes in the pkg/util directory run the following commands:

go test ./... -coverprofile=coverage.out
go tool cover -html=coverage.out -o coverage.html
open coverage.html

Does this PR introduce a user-facing change?:

NONE

@karmada-bot karmada-bot added kind/feature Categorizes issue or PR as related to a new feature. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Aug 9, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.54%. Comparing base (37488bd) to head (95b421d).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5339      +/-   ##
==========================================
+ Coverage   28.53%   28.54%   +0.01%     
==========================================
  Files         632      632              
  Lines       43856    43856              
==========================================
+ Hits        12515    12520       +5     
+ Misses      30443    30439       -4     
+ Partials      898      897       -1     
Flag Coverage Δ
unittests 28.54% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@NishantBansal2003
Copy link
Contributor Author

Hey @XiShanYongYe-Chang, PTAL, and provide your valuable feedback.

@NishantBansal2003
Copy link
Contributor Author

Hi @XiShanYongYe-Chang, just pinging in case this PR was missed.

@XiShanYongYe-Chang
Copy link
Member

Thanks @NishantBansal2003
/assign

Copy link
Member

@XiShanYongYe-Chang XiShanYongYe-Chang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks~
/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2024
@karmada-bot karmada-bot merged commit e5b1298 into karmada-io:master Aug 13, 2024
12 checks passed
@RainbowMango RainbowMango added this to the v1.11 milestone Aug 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants