Added tests in pkg/binding for condition coverage

[yashpandey06]

What type of PR is this?

/kind feature

What this PR does / why we need it:
This PR adds comprehensive unit tests for the following functions in the binding package:

• needReviseReplicas
• divideReplicasByJobCompletions
  Which issue(s) this PR fixes:
  Fixes: [lfx-mentorship-2024-September-November] Enhance Karmada controller-manager and schedule testing coverage #5235

Changes Made

1. Added Unit Tests for needReviseReplicas:

   • Covered various scenarios including:
     • Replicas is zero.
     • Placement is nil.
     • Replica scheduling type is not divided.
     • Replica scheduling type is divided.

2. Added Unit Tests for divideReplicasByJobCompletions:

   • Covered various scenarios including:
     • Completions found.
     • Completions not found.
     • Error in NestedInt64.

Testing

• Ran all unit tests to ensure they pass.
• Verified that the new tests cover the intended scenarios and edge cases.

[yashpandey06]

@XiShanYongYe-Chang please help review this PR

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.83%. Comparing base (bcefb22) to head (7bef098).
Report is 33 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5388      +/-   ##
==========================================
+ Coverage   29.41%   29.83%   +0.42%     
==========================================
  Files         632      632              
  Lines       43835    43936     +101     
==========================================
+ Hits        12892    13109     +217     
+ Misses      30003    29868     -135     
- Partials      940      959      +19     

Flag	Coverage Δ
unittests	29.83% <ø> (+0.42%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[XiShanYongYe-Chang]

Ok, thanks @yashpandey06
/assign

By the way, would you like to review the ut tests submitted by others? It's not mandatory, you can do it as you wish, and it's an important contribution to the community. Thank you very much! (I highly encourage you to review each other. My perspective may be subjective, but you can discuss it fully and provide more valuable review comments.)

[yashpandey06]

Ok, thanks @yashpandey06
/assign

By the way, would you like to review the ut tests submitted by others? It's not mandatory, you can do it as you wish, and it's an important contribution to the community. Thank you very much! (I highly encourage you to review each other. My perspective may be subjective, but you can discuss it fully and provide more valuable review comments.)

@XiShanYongYe-Chang , sure I would like to review uts submitted by other , that would be fun and great learning as well 😁

[anujagrawal699]

@yashpandey06 You can also review my PR's : #5366. Thanks!

[anujagrawal699]

@yashpandey06 Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using go test -coverprofile=coverage.out.

[yashpandey06]

@yashpandey06 Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using go test -coverprofile=coverage.out.

Thanks man ! For the review , but my wasn't the coverage of 100 % , making sure the repos atleast the average safety coverage of 40 to 50 %. And coming to to checking the report i already made a report based on it .

[yashpandey06]

@yashpandey06 Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using go test -coverprofile=coverage.out.

Thanks man ! For the review , but my wasn't the coverage of 100 % ( LFX Mentorship serves this purpose specifically ) , making sure the repos atleast the average safety coverage of 40 to 50 %. And coming to to checking the report i already made a report based on it .

[yashpandey06]

@yashpandey06 You can also review my PR's : #5366. Thanks!

Yup ! , currently I am away from my home town so doesn't have acces to my setup , but I ll be reaching there by tomorrow, so would be reviewing many prs for sure 😁.

[XiShanYongYe-Chang]

Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using go test -coverprofile=coverage.out.

That's okay. If some files are large and difficult to improve overall, and only some of the functions in the file are improved at a time, you can state which methods are improved in the PR description.

[yashpandey06]

Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using go test -coverprofile=coverage.out.

That's okay. If some files are large and difficult to improve overall, and only some of the functions in the file are improved at a time, you can state which methods are improved in the PR description.

Already did so ...thanks for the information 🙂

[anujagrawal699]

@yashpandey06 Try to add more tests, it only improved the test of coverage of binding controller by 1%. You can verify it in the file directory using go test -coverprofile=coverage.out.

Thanks man ! For the review , but my wasn't the coverage of 100 % , making sure the repos atleast the average safety coverage of 40 to 50 %. And coming to to checking the report i already made a report based on it .

Okay, thanks for the PR. /lgtm

[yashpandey06]

@XiShanYongYe-Chang, here are the required changes

[XiShanYongYe-Chang]

Thanks~
/lgtm
/approve

[karmada-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: XiShanYongYe-Chang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/controllers/OWNERS [XiShanYongYe-Chang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment