-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
standardize the naming of karmada secrets in local up method #5423
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5423 +/- ##
==========================================
+ Coverage 38.59% 39.74% +1.15%
==========================================
Files 649 650 +1
Lines 45133 55131 +9998
==========================================
+ Hits 17417 21913 +4496
- Misses 26380 31811 +5431
- Partials 1336 1407 +71
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
cef66b8
to
6d3843d
Compare
/assign |
6d3843d
to
6114547
Compare
@zhzhuang-zju can you help review this PR first, and if this PR is okey, I will continue to put forward the other three installation method just referring this. |
sure, I'll go through this pr first |
Generally LGTM, and you could fix the conflicts first |
687b770
to
c5e03ee
Compare
aa909d1
to
6278790
Compare
6278790
to
2b249ac
Compare
63170c4
to
28fca6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
28fca6b
to
c03a918
Compare
bbae1ab
to
18944b6
Compare
@RainbowMango this PR is ready~ |
$kubectl get secret -n karmada-system
NAME TYPE DATA AGE
etcd-cert kubernetes.io/tls 3 65m
etcd-etcd-client-cert kubernetes.io/tls 3 65m
karmada-aggregated-apiserver-cert kubernetes.io/tls 3 65m
karmada-aggregated-apiserver-config Opaque 1 65m
karmada-aggregated-apiserver-etcd-client-cert kubernetes.io/tls 3 65m
karmada-apiserver-cert kubernetes.io/tls 3 65m
karmada-apiserver-etcd-client-cert kubernetes.io/tls 3 65m
karmada-apiserver-front-proxy-client-cert kubernetes.io/tls 3 65m
karmada-apiserver-service-account-key-pair Opaque 2 65m
karmada-controller-manager-config Opaque 1 65m
karmada-descheduler-config Opaque 1 65m
karmada-descheduler-scheduler-estimator-client-cert kubernetes.io/tls 3 65m
karmada-interpreter-webhook-example-cert kubernetes.io/tls 3 65m
karmada-interpreter-webhook-example-config Opaque 1 65m
karmada-metrics-adapter-cert kubernetes.io/tls 3 65m
karmada-metrics-adapter-config Opaque 1 65m
karmada-scheduler-config Opaque 1 65m
karmada-scheduler-scheduler-estimator-client-cert kubernetes.io/tls 3 65m
karmada-search-cert kubernetes.io/tls 3 65m
karmada-search-config Opaque 1 65m
karmada-search-etcd-client-cert kubernetes.io/tls 3 65m
karmada-webhook-cert kubernetes.io/tls 3 65m
karmada-webhook-config Opaque 1 65m
kube-controller-manager-ca-cert kubernetes.io/tls 2 65m
kube-controller-manager-config Opaque 1 65m
kube-controller-manager-service-account-key-pair Opaque 2 65m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
Signed-off-by: chaosi-zju <[email protected]>
18944b6
to
edb224d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
In karmada, here are two important secrets, which is mount by most karmada components. One is karmada-cert, which contains a series of cert files like ca.crt, apiserver.crt and so on; another is karmada-kubeconfig, which contains a kubeconfig of karmada-apiserver.
However, in different installation methods, we used inconsistent secret naming or file path naming, which can potentially cause some unnecessary problems, detail refer to #5363.
This PR aims to standardize the naming of karmada secrets in local up installation method.
Which issue(s) this PR fixes:
Fixes part of #5363
Special notes for your reviewer:
Does this PR introduce a user-facing change?: