-
Notifications
You must be signed in to change notification settings - Fork 885
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing autocompletion for karmadactl #5533
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5533 +/- ##
==========================================
+ Coverage 32.45% 33.93% +1.48%
==========================================
Files 643 645 +2
Lines 44497 44857 +360
==========================================
+ Hits 14440 15223 +783
+ Misses 28962 28478 -484
- Partials 1095 1156 +61
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
387d748
to
cd341dd
Compare
Looks great! Can't wait to try it! |
The introduction of |
Currently,
Here are the autocompletion capabilities provided by
$ k
... karmadactl ... kubectl ...
$ karmadactl
addons -- Enable or disable a Karmada addon
annotate -- Update the annotations on a resource
api-resources -- Print the supported API resources on the server
$ karmadactl exec --operation-scope
karmada members
$ karmadactl get --operation-scope
all karmada members
$ karmadactl get
apiservices.apiregistration.k8s.io endpoints nodes.metrics.k8s.io resourceregistries.search.karmada.io
...
$ karmadactl get pods
nginx pod1 Highlights
Using the
|
cd341dd
to
aaa0233
Compare
its a great improvement for karmadactl, do u need update autocompletion to the karmada docs? |
yes, we can publish a guidance document as long as this pr is merged. Are you willing to submit a pr for this? |
6eb8eb4
to
b2110a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nits, otherwise LGTM.
Signed-off-by: zhzhuang-zju <[email protected]>
b2110a3
to
a684edd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Great job!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Implementing autocompletion for karmadactl, which can save you a lot of typing.
Which issue(s) this PR fixes:
Parts of #5477
Special notes for your reviewer:
Does this PR introduce a user-facing change?: