Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove extra slash when constructing member cluster URL to adapt… #5557

Open
wants to merge 1 commit into
base: release-1.9
Choose a base branch
from

Conversation

spiritNO1
Copy link
Contributor

… the apiEndpoint of the cluster object ends with a slash.

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #5455

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

karmada-aggregated-apiserver: User can append a "/" at the end when configuring the cluster's apiEndpoint.

… the apiEndpoint of the cluster object ends with a slash.

Signed-off-by: 圣朋 <[email protected]>
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xishanyongye-chang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 16, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants