-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test helm chart with the latest code #5909
Conversation
dfca7f2
to
a437c24
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #5909 +/- ##
==========================================
+ Coverage 47.52% 47.84% +0.31%
==========================================
Files 663 663
Lines 54755 54761 +6
==========================================
+ Hits 26025 26200 +175
+ Misses 27032 26854 -178
- Partials 1698 1707 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ready to review @RainbowMango |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/assign
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see a lot of duplicated code with /hack/local-up-karmada.sh.
Could this script be used as a base of it?
Yes, sure, the next step is use this script as the base of other local_up script. |
45a1a87
to
6760706
Compare
/hold as I has set It's strange why only |
6760706
to
1d7f59b
Compare
/unhold fixed |
1d7f59b
to
b94f2a8
Compare
/unhold |
Signed-off-by: chaosi-zju <[email protected]>
b94f2a8
to
16e7a0e
Compare
/retitle Test helm chart with the latest code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RainbowMango The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind flake
/kind feature
What this PR does / why we need it:
install karmada with latest tag images in ci chart-testing
Which issue(s) this PR fixes:
Fixes #5436
Special notes for your reviewer:
Does this PR introduce a user-facing change?: