Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test helm chart with the latest code #5909

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

chaosi-zju
Copy link
Member

What type of PR is this?

/kind flake
/kind feature

What this PR does / why we need it:

install karmada with latest tag images in ci chart-testing

Which issue(s) this PR fixes:

Fixes #5436

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@karmada-bot karmada-bot added kind/flake Categorizes issue or PR as related to a flaky test. kind/feature Categorizes issue or PR as related to a new feature. labels Dec 5, 2024
@karmada-bot karmada-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 5, 2024
@chaosi-zju chaosi-zju force-pushed the chart-install branch 4 times, most recently from dfca7f2 to a437c24 Compare December 5, 2024 06:25
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.84%. Comparing base (616a95e) to head (16e7a0e).
Report is 6 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5909      +/-   ##
==========================================
+ Coverage   47.52%   47.84%   +0.31%     
==========================================
  Files         663      663              
  Lines       54755    54761       +6     
==========================================
+ Hits        26025    26200     +175     
+ Misses      27032    26854     -178     
- Partials     1698     1707       +9     
Flag Coverage Δ
unittests 47.84% <ø> (+0.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chaosi-zju
Copy link
Member Author

ready to review @RainbowMango

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a lot of duplicated code with /hack/local-up-karmada.sh.
Could this script be used as a base of it?

hack/prepare-local-clusters.sh Outdated Show resolved Hide resolved
hack/prepare-local-clusters.sh Outdated Show resolved Hide resolved
hack/prepare-local-clusters.sh Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

I see a lot of duplicated code with /hack/local-up-karmada.sh. Could this script be used as a base of it?

Yes, sure, the next step is use this script as the base of other local_up script.

@chaosi-zju chaosi-zju force-pushed the chart-install branch 2 times, most recently from 45a1a87 to 6760706 Compare December 5, 2024 09:03
@chaosi-zju
Copy link
Member Author

/hold

as I has set --helm-extra-set-args '--set components={"metricsAdapter,search,descheduler"}',

It's strange why only karmada-search of the optional components is installed.

@karmada-bot karmada-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 5, 2024
@chaosi-zju
Copy link
Member Author

It's strange why only karmada-search of the optional components is installed.

/unhold fixed

.github/workflows/chart-lint-and-installation.yaml Outdated Show resolved Hide resolved
.github/workflows/chart-lint-and-installation.yaml Outdated Show resolved Hide resolved
.github/workflows/chart-lint-and-installation.yaml Outdated Show resolved Hide resolved
hack/setup-dev-base.sh Outdated Show resolved Hide resolved
hack/setup-dev-base.sh Outdated Show resolved Hide resolved
@chaosi-zju
Copy link
Member Author

/unhold

@karmada-bot karmada-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 6, 2024
@RainbowMango
Copy link
Member

/retitle Test helm chart with the latest code

@karmada-bot karmada-bot changed the title install karmada with latest tag images in ci chart-testing Test helm chart with the latest code Dec 6, 2024
Copy link
Member

@RainbowMango RainbowMango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@karmada-bot karmada-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2024
@karmada-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RainbowMango

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@karmada-bot karmada-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2024
@RainbowMango RainbowMango added this to the v1.13 milestone Dec 6, 2024
@karmada-bot karmada-bot merged commit 07157e6 into karmada-io:master Dec 6, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. kind/flake Categorizes issue or PR as related to a flaky test. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm chart testing enhancement
4 participants