-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict the cluster sync mode for the unjoin and unregister command #6081
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: zhzhuang-zju <[email protected]>
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #6081 +/- ##
==========================================
- Coverage 48.35% 48.31% -0.05%
==========================================
Files 666 666
Lines 54874 54903 +29
==========================================
- Hits 26535 26527 -8
- Misses 26615 26645 +30
- Partials 1724 1731 +7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No data was changed or removed before this log, right? |
Yes, I put the validations ahead of the |
/retest |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Restrict the cluster sync mode for the unjoin and unregister command.
Which issue(s) this PR fixes:
Fixes #801
Special notes for your reviewer:
Does this PR introduce a user-facing change?: