Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/14 instance of planprat #65

Merged
merged 24 commits into from
Nov 8, 2024
Merged

Feat/14 instance of planprat #65

merged 24 commits into from
Nov 8, 2024

Conversation

ArtemisAaroe
Copy link
Collaborator

@ArtemisAaroe ArtemisAaroe commented Oct 31, 2024 •
edited by andreaslhjulstad
Loading

Closes #66, #14

  • fake planprat backend
  • component to display fake planprat responses and take input from user

for revuer: sverre could run this but i could not. so make sure you can actualy run this. if sombody else can then its probably a problem on my end.

@ArtemisAaroe ArtemisAaroe self-assigned this Oct 31, 2024
@ArtemisAaroe ArtemisAaroe linked an issue Oct 31, 2024 that may be closed by this pull request
Instance of Planprat #14
Closed
@ArtemisAaroe ArtemisAaroe requested review from andreaslhjulstad and removed request for SverreNystad October 31, 2024 06:41
andreaslhjulstad
andreaslhjulstad reviewed Oct 31, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
andreaslhjulstad
andreaslhjulstad requested changes Oct 31, 2024
View reviewed changes
Copy link
Collaborator

@andreaslhjulstad andreaslhjulstad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Some changes need to be made to make it run (crashes in CI pipeline).

Edit: No longer crashes, but some changes are still needed for clean code

SverreNystad
SverreNystad reviewed Nov 6, 2024
View reviewed changes
docker-compose.yml Outdated Show resolved Hide resolved
node_modules/@types/js-cookie/LICENSE Outdated Show resolved Hide resolved
...y.ts/for-soknad-dashbord e2e Tests -- should render content -- before each hook (failed).png Outdated Show resolved Hide resolved
webapp/src/components/PlanPrat.tsx Outdated Show resolved Hide resolved
webapp/src/components/PlanPrat.tsx Outdated Show resolved Hide resolved
webapp/src/components/PlanPrat.tsx Outdated Show resolved Hide resolved
webapp/src/server/api/routers/planprat.ts Show resolved Hide resolved
andreaslhjulstad
andreaslhjulstad approved these changes Nov 8, 2024
View reviewed changes
Copy link
Collaborator

@andreaslhjulstad andreaslhjulstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andreaslhjulstad andreaslhjulstad merged commit 1233c1e into main Nov 8, 2024
1 check passed
@andreaslhjulstad andreaslhjulstad deleted the feat/14-instance-of-planprat branch November 8, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SverreNystad SverreNystad SverreNystad left review comments

@andreaslhjulstad andreaslhjulstad andreaslhjulstad approved these changes

Assignees

@ArtemisAaroe ArtemisAaroe

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Planprat CORS issue Instance of Planprat
3 participants
@ArtemisAaroe @SverreNystad @andreaslhjulstad