Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid remove of just added item from LRU cache #2057

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

biospb
Copy link
Contributor

@biospb biospb commented May 20, 2022

It can be very critical for small capacity caches like pruningStore

@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #2057 (2faa3d0) into dev (4dd7113) will increase coverage by 0.04%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##              dev    #2057      +/-   ##
==========================================
+ Coverage   59.32%   59.36%   +0.04%     
==========================================
  Files         673      673              
  Lines       32355    32355              
==========================================
+ Hits        19195    19208      +13     
+ Misses      10393    10383      -10     
+ Partials     2767     2764       -3     
Impacted Files Coverage Δ
...air/lrucachehashpairtoblockghostdagdatahashpair.go 59.45% <75.00%> (ø)
domain/consensus/utils/lrucache/lrucache.go 100.00% <100.00%> (ø)
...utils/lrucacheghostdagdata/lrucacheghostdagdata.go 89.18% <100.00%> (ø)
...hehashandwindowsizetoblockghostdagdatahashpairs.go 89.18% <100.00%> (ø)
...utils/lrucacheuint64tohash/lrucacheuint64tohash.go 89.65% <100.00%> (ø)
...k/netadapter/server/grpcserver/connection_loops.go 56.89% <0.00%> (-5.18%) ⬇️
infrastructure/network/netadapter/router/route.go 72.72% <0.00%> (-4.55%) ⬇️
.../protocol/flows/v5/blockrelay/handle_relay_invs.go 52.63% <0.00%> (-1.22%) ⬇️
app/protocol/flows/v5/blockrelay/ibd.go 46.06% <0.00%> (+0.92%) ⬆️
...ocol/flows/v5/blockrelay/ibd_with_headers_proof.go 44.67% <0.00%> (+1.22%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4dd7113...2faa3d0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant