forked from cockroachdb/cockroach
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Browse files
Browse the repository at this point in the history
…achdb#111088 cockroachdb#111211 cockroachdb#111240 cockroachdb#111252 cockroachdb#111277 104634: cloud,backupccl: add metric for time of last backup failure due to KMS r=rhu713 a=rhu713 Add a metric `backup.last-failed-time.kms-inaccessible` that tracks the timestamp of the last backup failure due to a KMS error. This metric is only tracked for BACKUP statrements that are executed with the OPTION `updates_cluster_monitoring_metrics` set. Release note (sql change): adds the `updates_cluster_monitoring_metrics` backup option that allows an operator to opt-in tracking the timestamp of the last backup failure due to a KMS error. 111049: c2c: add external connection tests r=stevendanna a=msbutler This patch increases test coverage for replication streams created with an external connection to source. Specifically, this patch adds a dedicated External Connection client test and metamorphically creates the c2c e2e tests with an external connection. Fixes: cockroachdb#110449 Release note: None 111074: bulk: add histograms to ingestion performance stats r=stevendanna a=adityamaru This change adds two histograms to the IngestionPerformanceStats. A histogram that tracks the batch wait, and one that tracks the SST data size. This change also adds a count for the number of ssts that are ingested as write batches. Release note: None Informs: cockroachdb#108374 111088: kvflowcontrol: signaling bug fix and per-stream stats r=aadityasondhi a=sumeerbhola The signaling logic had a bug, which is demonstrated by TestBucketSignalingBug: if an elastic waiter consumed the entry in signalCh, a regular waiter would not get unblocked if regular tokens became positive. Per-stream stats are added for the duration when there were no tokens, and the tokens deducted. These are reset every time the stats are logged, so the caller can easily interpret the log entries as the delta since the previous log entry. It will give us visibility into per stream behavior at a 30s granularity. The code abstractions are re-worked. More of the logic is abstracted inside `bucket` and `bucketPerWorkClass` instead of exposing internals to `Controller`. Epic: none Release note: None 111211: backupccl: simplify test removing unnecessary params r=arulajmani,stevendanna a=andrewbaptist Remove the disabling of many of the jobs to simplify TestRestoreErrorPropagates as it was previously attempting to match any key to the range, now it only matches values with RESTORE in them. Epic: none Release note: None 111240: oidc: use relative paths in db-console r=knz a=dhartunian Previous changes to make all DB Console paths relative overlooked the OIDC URLs. Epic: None Part of: cockroachdb#91429 Release note (ui change): DB Console instances proxied at different subpaths, that use OIDC will point to the correct relative path when attempting to use OIDC login. 111252: sql: use precise capacity for row container in a few places r=yuzefovich a=yuzefovich This commit audits all callers of `newContainerValuesNode` to specify the precise capacity of the underlying row container since in all places we know upfront how many rows the valuesNode will have. (Just happened to notice it while working around one of those places.) Epic: None Release note: None 111277: go.mod: bump Pebble to 660450027a8c r=RaduBerinde a=jbowens ``` 66045002 sharedcache: tolerate small sizes 895ffed5 db: add SkipPoint iterator option a48ac0f4 db: use uncompensated scores to prioritize levels for compaction ``` Epic: none Release note (performance improvement): Improved compaction heuristics mitigate read amplification growth and admission control throttling when processing large deletes (eg, during decommissions, replica rebalancing, DROP TABLEs, etc). Co-authored-by: Rui Hu <[email protected]> Co-authored-by: Michael Butler <[email protected]> Co-authored-by: adityamaru <[email protected]> Co-authored-by: sumeerbhola <[email protected]> Co-authored-by: Andrew Baptist <[email protected]> Co-authored-by: David Hartunian <[email protected]> Co-authored-by: Yahor Yuzefovich <[email protected]> Co-authored-by: Jackson Owens <[email protected]>
- Loading branch information
Showing
62 changed files
with
1,555 additions
and
404 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1599,10 +1599,10 @@ def go_deps(): | |
| patches = [ | ||
| "@com_github_cockroachdb_cockroach//build/patches:com_github_cockroachdb_pebble.patch", | ||
| ], | ||
| sha256 = "f85cd2d80b88bc9a43f02879b855205de580417e3d2250b0e3db86b130d630d1", | ||
| strip_prefix = "github.com/cockroachdb/[email protected]20230922144958-86593692e09f", | ||
| sha256 = "ae597247d1467f844be951b446bb125919418c4efeb581534968f82ae5f2df17", | ||
| strip_prefix = "github.com/cockroachdb/[email protected]20230926003129-660450027a8c", | ||
| urls = [ | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230922144958-86593692e09f.zip", | ||
| "https://storage.googleapis.com/cockroach-godeps/gomod/github.com/cockroachdb/pebble/com_github_cockroachdb_pebble-v0.0.0-20230926003129-660450027a8c.zip", | ||
| ], | ||
| ) | ||
| go_repository( | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| // Copyright 2023 The Cockroach Authors. | ||
| // | ||
| // Licensed as a CockroachDB Enterprise file under the Cockroach Community | ||
| // License (the "License"); you may not use this file except in compliance with | ||
| // the License. You may obtain a copy of the License at | ||
| // | ||
| // https://github.com/cockroachdb/cockroach/blob/master/licenses/CCL.txt | ||
|
|
||
| package backupccl | ||
|
|
||
| import ( | ||
| "time" | ||
|
|
||
| "github.com/cockroachdb/cockroach/pkg/jobs" | ||
| "github.com/cockroachdb/cockroach/pkg/util/metric" | ||
| ) | ||
|
|
||
| type BackupMetrics struct { | ||
| LastKMSInaccessibleErrorTime *metric.Gauge | ||
| } | ||
|
|
||
| // MetricStruct implements the metric.Struct interface. | ||
| func (b BackupMetrics) MetricStruct() {} | ||
|
|
||
| // MakeBackupMetrics instantiates the metrics for backup. | ||
| func MakeBackupMetrics(time.Duration) metric.Struct { | ||
| m := &BackupMetrics{ | ||
| LastKMSInaccessibleErrorTime: metric.NewGauge(metric.Metadata{ | ||
| Name: "backup.last-failed-time.kms-inaccessible", | ||
| Help: "The unix timestamp of the most recent failure of backup due to errKMSInaccessible by a backup specified as maintaining this metric", | ||
| Measurement: "Jobs", | ||
| Unit: metric.Unit_TIMESTAMP_SEC, | ||
| }), | ||
| } | ||
| return m | ||
| } | ||
|
|
||
| func init() { | ||
| jobs.MakeBackupMetricsHook = MakeBackupMetrics | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.