edits for tutorial draft #1
Conversation
| - MONGO_PASSWORD=$MONGO_PASSWORD | ||
| - MONGO_HOSTNAME=$MONGO_HOSTNAME | ||
| - MONGO_PORT=$MONGO_PORT | ||
| - MONGO_DB=$MONGO_DB |
There was a problem hiding this comment.
Would set the MONGO_HOSTNAME variable to db explicitly here, instead of setting it to db in the config parameter file. Would either leave it blank/unset or omit it from that file entirely. db is a "Compose-level" variable, so referring to it at the Compose level makes more sense and is cleaner, IMO. See comment on Tutorial markdown.
| container_name: db | ||
| restart: unless-stopped | ||
| environment: | ||
| - MONGO_INITDB_ROOT_USERNAME=user |
There was a problem hiding this comment.
Would avoid checking these (even more) sensitive parameters into version control. Would create a separate .env file (or use the same file) and externalize these from the Dockerfile.
| @@ -0,0 +1,79 @@ | |||
| #!/bin/sh | |||
|
|
|||
There was a problem hiding this comment.
Would maybe add a comment in the script linking out to the original on GH.
| @@ -5,3 +5,5 @@ Dockerfile | |||
| .git | |||
| README.md | |||
| .gitignore | |||
| .env | |||
| db-init.js | |||
There was a problem hiding this comment.
Would check db-init.js into version control (since it is code that gets executed), and modify the script so it pulls config/sensitive info from the already configured .env file. All config should be centralized and removed from code (and all code that is run should be checked in to VC).
| @@ -76,4 +76,5 @@ typings/ | |||
| .fusebox/ | |||
|
|
|||
| #DynamoDB Local files | |||
| .dynamodb/ | |||
| .dynamodb/ | |||
| db-init.js | |||
No description provided.