Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pyyaml to next major version #223

Merged
merged 43 commits into from
Aug 22, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
43 commits
Select commit Hold shift + click to select a range
870aa91
Removed parallelization limit.
ognjen-j Nov 18, 2019
5c6a5a5
Merge branch 'master' into move-integration-tests-to-parallel
ognjen-j Nov 18, 2019
af4d42c
Release test.
ognjen-j Nov 18, 2019
9d5bc97
Uncomment the publishing step.
ognjen-j Nov 18, 2019
cb1571e
Prepare release 0.2.0b0
ognjen-j Nov 19, 2019
189adf6
Version changed to 0.2.0b0
ognjen-j Nov 19, 2019
08854d4
Removed the tag check.
ognjen-j Nov 19, 2019
7c90602
Workflow optimizations.
ognjen-j Nov 19, 2019
b081b7a
Modified the version test.
ognjen-j Nov 19, 2019
f31638c
Modified the version test.
ognjen-j Nov 19, 2019
9433bc6
Changed the development status classifier
ognjen-j Nov 19, 2019
996bb80
Merge branch 'master' into release-prep
ognjen-j Oct 6, 2020
bad9cff
Version changed to v0.2.3a1
ognjen-j Oct 6, 2020
81a5220
Version changed to v0.2.3
ognjen-j Oct 7, 2020
ab4adf1
Merge branch 'master' into release-prep
ognjen-j Oct 19, 2020
2251a57
Version 0.2.4 released.
ognjen-j Oct 19, 2020
02c10bc
Merge branch 'master' into release-prep
ognjen-j Oct 27, 2020
2270f00
Version changed to v0.2.5"
ognjen-j Oct 27, 2020
a70d01e
Merge branch 'master' into release-prep
ognjen-j Nov 11, 2020
7d1c9e6
Version changed to v0.2.6
ognjen-j Nov 11, 2020
3f576b1
Merge branch 'master' of https://github.com/real-digital/esque into r…
ognjen-j Nov 25, 2020
40a2361
Version changed to v0.2.7
ognjen-j Nov 25, 2020
b17d58c
Merge branch 'master' into release-prep
ognjen-j Dec 3, 2020
b792f14
Version changed to v0.2.8
ognjen-j Dec 3, 2020
b9a37b7
Merge branch 'master' into release-prep
ognjen-j May 28, 2021
47136b3
Version changed to v0.3.1
ognjen-j May 28, 2021
fb11de4
devpi pipeline fix
ognjen-j May 28, 2021
98795f1
Try starting the devpi-server in the background.
ognjen-j May 28, 2021
cc26e4e
Redirect devpi logs to a file and output them in case of failure.
ognjen-j May 28, 2021
14a59a0
Merge branch 'master' into release-prep
ognjen-j Nov 25, 2021
3b01f79
Version changed to v0.4.1
ognjen-j Nov 25, 2021
f1018f2
Merge branch 'master' into release-prep
Aug 2, 2022
fc8b8c4
Version changed to v0.5.0
Aug 2, 2022
15b16bd
Merge branch 'master' into release-prep
Aug 5, 2022
7ddc20a
Version changed to v0.5.1
Aug 5, 2022
81c234d
Merge branch 'master' into release-prep
Mar 2, 2023
d807ee1
Update CHANGELOG.md and pyproject.toml version
Mar 2, 2023
286c95c
Typo in test case. All tests passing now
Apr 14, 2023
a641730
Update pyyaml to next stable version, currently broken
Aug 16, 2023
e3f0431
Merge branch 'master' into update_pyyaml
Aug 16, 2023
c5f745f
Update type comparisons which were highlighted by the linter
Aug 22, 2023
abf8778
Update pointer for debian files, as they have been archived
Aug 22, 2023
6d4ffe1
Incorrect use of isinstance(). Tests throw no errors
Aug 22, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions esque/cli/output.py
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ def pretty_duration(value: Any, *, multiplier: int = 1) -> str:
if not value:
return ""

if type(value) != int:
if type(value) is not int:
value = int(value)

value *= multiplier
Expand Down Expand Up @@ -193,7 +193,7 @@ def pretty_offset_plan(offset_plan: List[ConsumerGroupOffsetPlan]):


def pretty_size(value: Any) -> str:
if type(value) != int:
if type(value) is not int:
value = int(value)
units = [
("Eib", 1024**6),
Expand Down
2 changes: 1 addition & 1 deletion esque/io/stream_events.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def __repr__(self) -> str:
def __eq__(self, other):
if not isinstance(other, StreamEvent):
return NotImplemented
return type(self) == type(other) and self._msg == other._msg and self.partition == other.partition
return type(self) is type(other) and self._msg == other._msg and self.partition == other.partition


class NthMessageRead(StreamEvent):
Expand Down
4 changes: 2 additions & 2 deletions esque/resources/topic.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class AttributeDiff:
def __init__(self, remote, local):
self.remote = remote
self.local = local
assert type(remote) == type(
assert type(remote) is type(
local
), f"Attributes should be given as the same type, not {type(remote)} and {type(local)}"

Expand Down Expand Up @@ -92,7 +92,7 @@ def set_diff(self, name: str, remote, local) -> "TopicDiff":
if local is None:
return self

assert type(remote) == type(
assert type(remote) is type(
local
), f"Attributes for {name} should be given as the same type, not {type(remote)} and {type(local)}"
self._diffs[name] = AttributeDiff(remote, local)
Expand Down
5 changes: 5 additions & 0 deletions kafka.Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
FROM openjdk:11-jdk-stretch


RUN sed -i s/deb.debian.org/archive.debian.org/g /etc/apt/sources.list
RUN sed -i 's|security.debian.org|archive.debian.org|g' /etc/apt/sources.list
RUN sed -i '/stretch-updates/d' /etc/apt/sources.list

RUN apt-get update -q \
&& apt install \
-qqy -o=Dpkg::Use-Pty=0 \
Expand Down
514 changes: 267 additions & 247 deletions poetry.lock

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ confluent-kafka = {version = "^1.6", extras = ["avro"]}
fastavro = "^1.0"
pendulum = "^2.0"
kafka-python = "^2.0.2"
pyyaml = "^5.1"
pyyaml = "6.0.1"
requests = "^2.22"
yamale = ">=2,<4"
toml = "^0.10.0"
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/commands/test_describe.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,15 +151,15 @@ def test_describe_broker_from_stdin(

def check_described_topic(described_topic: Union[str, dict]):
topic_description_keys = ["topic", "partitions", "config"]
if type(described_topic) == str:
if type(described_topic) is str:
for option in topic_description_keys:
assert option in described_topic
else:
assert list(described_topic.keys()) == topic_description_keys


def check_described_broker(described_broker: Union[str, dict]):
if type(described_broker) == str:
if type(described_broker) is str:
for option in VARIOUS_IMPORTANT_BROKER_OPTIONS:
assert option in described_broker
else:
Expand Down
4 changes: 2 additions & 2 deletions tests/integration/commands/test_produce.py
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

import confluent_kafka
import pytest
from _pytest.tmpdir import TempdirFactory
from _pytest.tmpdir import TempPathFactory
from click.testing import CliRunner
from confluent_kafka.cimpl import Consumer, TopicPartition
from pytest_cases import fixture
Expand Down Expand Up @@ -44,7 +44,7 @@ def test_produce_can_create_topic(
consumer_factory: Callable[[str], Consumer],
non_interactive_cli_runner: CliRunner,
topic_id: str,
tmpdir_factory: TempdirFactory,
tmpdir_factory: TempPathFactory,
):
data = json.dumps(dict(key="key1", value="value1")) + "\n"
result = non_interactive_cli_runner.invoke(
Expand Down
4 changes: 2 additions & 2 deletions tests/unit/test_output.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ def check_loaded_dict(original_dict: dict, loaded_dict: dict):
for key in original_dict.keys():
assert key in loaded_dict
original_value = original_dict[key]
if type(original_value) == tuple:
if type(original_value) is tuple:
assert list(original_value) == loaded_dict[key]
elif type(original_value) == bytes:
elif type(original_value) is bytes:
assert original_value.decode("UTF-8") == loaded_dict[key]
else:
assert original_value == loaded_dict[key]
Expand Down
Loading