Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

32 describe consumergroup show topic #35

Closed
wants to merge 4 commits into from
Closed

32 describe consumergroup show topic #35

wants to merge 4 commits into from

Conversation

b-boehne
Copy link
Contributor

@b-boehne b-boehne commented Aug 8, 2019

fixes #32
setting consumer-id argument to required seemed sensible, tell me if there's a use case i didn't see

@b-boehne b-boehne requested a review from hfjn August 8, 2019 11:56
@b-boehne
Copy link
Contributor Author

b-boehne commented Aug 8, 2019

Oh, just noticed the tests. Will update my PR later.

hfjn
hfjn reviewed Aug 8, 2019
View reviewed changes
esque/consumergroup.py Outdated Show resolved Hide resolved
@hfjn
Copy link
Contributor

hfjn commented Sep 23, 2019

You still have merge conflict. :(

@swenzel
Copy link
Contributor

swenzel commented Sep 23, 2019 •
edited
Loading

Could it be that this is actually outdated by now?
#53 will improve the describe consumergroup command already.

@hfjn
Copy link
Contributor

hfjn commented Sep 27, 2019

Fixed in #53

@hfjn hfjn closed this Sep 27, 2019
@swenzel swenzel deleted the 32-describe-consumergroup-show-topic branch April 7, 2020 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hfjn hfjn hfjn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

esque describe consumergroup doesn't show topic for offset summary
3 participants
@b-boehne @hfjn @swenzel