Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release/0.1.0 #20

Closed
wants to merge 2 commits into from
Closed

Release/0.1.0 #20

wants to merge 2 commits into from

Conversation

cmp0xff
Copy link
Collaborator

@cmp0xff cmp0xff commented Mar 10, 2024

No description provided.

cmp0xff and others added 2 commits March 10, 2024 22:51
* feat(commitizen): #18 add commitizen to dependencies

* doc(README): #18 describe publish process
@cmp0xff cmp0xff added the enhancement New feature or request label Mar 10, 2024
@cmp0xff cmp0xff requested a review from emptymalei March 10, 2024 22:02
@cmp0xff cmp0xff self-assigned this Mar 10, 2024
Copy link
Contributor

github-actions bot commented Mar 10, 2024

✅ Result of Pytest Coverage

---------- coverage: platform darwin, python 3.11.8-final-0 ----------

Name Stmts Miss Cover
hamilflow/init.py 0 0 100%
hamilflow/models/init.py 0 0 100%
hamilflow/models/harmonic_oscillator.py 65 3 95%
TOTAL 65 3 95%
======================== 7 passed, 1

@@ -0,0 +1,5 @@
## 0.1.0 (2024-03-10)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have a changelog file in the docs folder.
https://github.com/kausalflow/hamilflow/blob/main/docs/changelog.md

Not sure which is better. Choose whichever you prefer.
We need a changelog file in the docs folder. But if you choose this current file, I can easily add a hook in the pre commit confit to automatically copy it to docs. So either ways.

@emptymalei
Copy link
Member

emptymalei commented Mar 11, 2024

Comment about releases:

It is easier to automate stuff it we have a tag for each release. It has not been configured yet but we will have a automatic releasing step in Actions. The step can be easily triggered by a tag such as v0.1.0.
We can discuss this later. Maybe there are better ways.

- Squash merge all features to a branch, e.g. `main` or `release/cmp0xff/candidate`
- Use `feat(section): xxx`, `fix(section): yyy`, `chore(poetry): lock` etc as the squashed commit messages
- Run `cz bump --dry` to determine the new version `X.Y.Z`. Or check out the [documentation](https://commitizen-tools.github.io/commitizen/bump/) for imposing a version
- Run `git checkout release/X.Y.Z` (-b? not sure... I have always been using SourceTree )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indeed -b is required

- Run `cz bump`. This will
- Write `CHANGELOG.md` from the commit messages; update the version in `pyproject.toml`
- Commit `CHANGELOG.md` and `pyproject.toml`
- Create a new tag
Copy link
Member

@emptymalei emptymalei Mar 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make it clear that tags should be added after the review of the PR.

@cmp0xff cmp0xff closed this Mar 12, 2024
@cmp0xff cmp0xff deleted the release/0.1.0 branch March 12, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants