-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(kepler-problem): #82 add tutorial #98
Conversation
Coverage Report (54749d5, 3.12, macos-latest)
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tutorial shows the trajectory, which is solved by the textbook Kepler problem. However, it does not show our strength in that the trajectory is parameterised by time. For example, can we use colour to indicate the speed?
Co-authored-by: cmp0xff <[email protected]>
Co-authored-by: cmp0xff <[email protected]>
good point. I added some animations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tutorial shows the basics and our strengths. I can approve it after this round of review.
- We need to fix the floating error when displaying
t
. Currently we see weird numbers like-3.299999999
,-3.199999999
,-3.1
, etc. If I were writing the code, I would divide 1 by a power of 2. - We can to make the animations more impressive.
- We need to make them smoother.
- For periodic orbits, we can do fewer revolutions.
- For unbounded motion, we should somehow emphasise that the motion near the vertex is faster.
Co-authored-by: cmp0xff <[email protected]>
Resolves #82