Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to empirically measure bandwidth for roofline #17 #23

Draft
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

nchristensen
Copy link
Collaborator

No description provided.

@kaushikcfd
Copy link
Owner

kaushikcfd commented Sep 21, 2022

Thanks! Some initial comments:

  • We should pass the lint CI on this.
  • This should hook into the current feinsum machinery where the device peak is pulled instead of an executable in the source tree.
    • I'm hoping with this the proposed patch will be picked up by the code paths CI as well.
  • [Minor] Better commit messages, otherwise, all the commits might get squashed. Typically commit boundaries that are good checkpoints for git-bisect are good options.

@nchristensen
Copy link
Collaborator Author

Yeah, the changes for each commit are pretty incremental so they can probably be squashed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants