forked from FuelLabs/sway-applications
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: nixified ci times #1
Open
kayagokalp
wants to merge
21
commits into
master
Choose a base branch
from
kayagokalp/nix-ci-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
ec34450
test: nixified ci
kayagokalp b75b506
Update .github/workflows/ci.yml
kayagokalp cc4bcdd
Update .github/workflows/ci.yml
kayagokalp c8315b7
Update .github/workflows/ci.yml
kayagokalp d949a19
Update .github/workflows/ci.yml
kayagokalp c4124ea
chore: try caching
kayagokalp c554410
try with beta-3 toolchain
kayagokalp 173e7f7
pin to toolchain to match upstream
kayagokalp 58bc56c
chore: try different versions
kayagokalp 70df253
trying cache miss by chaning version
kayagokalp 705a8fe
try complete cache hit
kayagokalp e67c52f
try removing caching
kayagokalp 3c3679a
try different version of forc
kayagokalp 3401ea2
try old release with caching enabled
kayagokalp e1a6c14
try old release with cached nix/store
kayagokalp fba4adf
fix cache key
kayagokalp 0ab463e
try old release with fixed key cached nix/store
kayagokalp 9334422
unpin the key and remove failing steps
kayagokalp c85f7f1
hit the cache
kayagokalp 3934a1a
fix environment variables
kayagokalp ef31a24
hit the cache
kayagokalp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -70,11 +70,14 @@ jobs: | |
- name: Init cache | ||
uses: Swatinem/rust-cache@v2 | ||
|
||
- name: Install Fuel toolchain | ||
uses: FuelLabs/[email protected] | ||
- name: Install fuel toolchain | ||
uses: cachix/install-nix-action@v21 | ||
with: | ||
toolchain: latest | ||
date: 2023-04-12 | ||
nix_path: nixpkgs=channel:nixos-unstable | ||
extra_nix_config: | | ||
extra-substituters = https://fuellabs.cachix.org | ||
extra-trusted-public-keys = fuellabs.cachix.org-1:3gOmll82VDbT7EggylzOVJ6dr0jgPVU/KMN6+Kf8qx8= | ||
- run: nix shell github:fuellabs/fuel.nix#forc-0-39-0 | ||
kayagokalp marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
- name: Check Sway formatting | ||
run: | | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the docs: https://github.com/cachix/install-nix-action#how-do-i-add-a-binary-cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets try that!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm from this docs, it looks like providing
extra_
prefix to nix config tells nix to append the given public key and substituters, rather than overriding already existing ones. In this case we overriden nixos cache and made the process slower i guess. (Since we had packages found from nixos cache rather than ours but with this change we only find the packages in our cache and re-build other ones). The default substituters ishttps://cache.nixos.org
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to enable experimental features here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the action has the
flake
experimental feature enabled by default, so I believe we should be good with the default settings (last bullet point in the linked section):https://github.com/cachix/install-nix-action#features
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I wasn't sure if that was being overridden due to this logic:
https://github.com/cachix/install-nix-action/blob/16b951426ed4927ca0d26d32e8f5a10638579ec8/install-nix.sh#L31