Fix warnings with gcc-12 & improve Makefile #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valijson uses picojson as a driver, and we found that building with gcc-12 and optimization (e.g. -O2) causes picojson to emit warnings, see the long story here. The most important one is the uninitialized storage warning, which only appears with optimization and gcc-12.
Since master had a few updates since the last release, the changes in this PR are fewer than for valijson, but they are still necessary to compile cleanly e.g. in projects that use -Werror (which is generally not recommended, but still..).
The Makefile fix allows to pass in CXXFLAGS to build/test with different optimization flags.